Log warning for SAMLRequests with IssueInstant older than 24 hours#2061
Merged
Conversation
johanib
approved these changes
Jul 20, 2026
johanib
left a comment
johanib
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Nitpick:
The commit message contains implementation details.
How does it address the issue?
This change adds a dedicated warning for severely stale AuthnRequests,
taking priority over the existing minor-drift notice so only the
single most-applicable message fires per request. The check is scoped
to AuthnRequests only, since Responses are handled differently and
weren't part of the reported issue. This is logging only, no
requests are blocked.
Why is this change needed? Prior to this change, EngineBlock only logged a generic clock-skew notice when an incoming message's IssueInstant differed from server time by more than 30 seconds, in either direction, for both AuthnRequests and Responses. There was no way to distinguish an SP sending severely stale AuthnRequests (>24h old, possibly indicating replay or a badly out-of-sync clock) from routine minor clock drift. How does it address the issue? This change adds a dedicated warning for severely stale AuthnRequests, taking priority over the existing minor-drift notice so only the single most-applicable message fires per request. The check is scoped to AuthnRequests only, since Responses are handled differently and weren't part of the reported issue. This is logging only, no requests are blocked. #1972
kayjoosten
force-pushed
the
feature/issue-1972-check-old-issueinstant
branch
from
July 21, 2026 09:13
8b0a5f4 to
58c7561
Compare
Contributor
Author
|
Only changed the commit message, doesnt need rereview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #1972