Consolidate simple feedback routes into generic feedbackAction#1992
Open
johanib wants to merge 5 commits intofeature/EB-1795_clear-sessinofrom
Open
Consolidate simple feedback routes into generic feedbackAction#1992johanib wants to merge 5 commits intofeature/EB-1795_clear-sessinofrom
johanib wants to merge 5 commits intofeature/EB-1795_clear-sessinofrom
Conversation
johanib
force-pushed
the
feature/EB-1758_declutter-error-handler
branch
from
c17d304 to
0e48997
Compare
johanib
force-pushed
the
feature/EB-1795_clear-sessino
branch
from
b50a07a to
f6b3d4a
Compare
feedbackInfo was stored as a flat dict in $_SESSION['feedbackInfo'] and merged with existing data on each write. This meant info collected during one auth flow (e.g. which IdP was involved) could appear on error pages in a completely separate flow. Additionally, currentServiceProvider and currentIdentityProvider were never cleared from the session after a successful login, so they would show up on error pages for unrelated early errors. The fix: - feedbackInfo is now keyed per SAML request ID so each auth flow has its own isolated bucket with no merging across flows - clearFlowContext() is called by ProcessedAssertionConsumer after a successful auth, clearing all flow context from the session - All session access moved from raw $_SESSION to the Symfony session - Session ops for feedbackInfo and flow context are centralised in a new FeedbackStateHelper class, split out from ProcessingStateHelper - FeedbackStateHelper is wired through DiContainerRuntime instead of the legacy DiContainer
Prior to this change, there were many 'empty' identical twig templates in the error process. This change replaces them with a 'generic-error' twig template. Resolves #1758
These templates were not using the 'new' translation key convention yet. (the old translation keys are not removed, because `invalid-acs-location` still references them).
johanib
force-pushed
the
feature/EB-1758_declutter-error-handler
branch
from
0e48997 to
edf1931
Compare
kayjoosten
reviewed
May 5, 2026
|
|
||
| The `error_invalid_acs_location` translation key has changed meaning. Previously it held the **error description** text. It now holds the **page title**. | ||
|
|
||
| If you have overridden this key in your theme translations (`theme/{name}/translations/messages.*.php`), rename it to `error_invalid_acs_location_desc` and add a new `error_invalid_acs_location` entry for the page title. |
Contributor
There was a problem hiding this comment.
Nice, but we are missing some key. You have also changed error_no_message, error_no_message_desc, error_stepup_callout_unknown_title and error_stepup_callout_user_cancelled_title.
| ``` | ||
|
|
||
| See https://github.com/OpenConext/OpenConext-engineblock/issues/1758 | ||
|
|
Contributor
There was a problem hiding this comment.
also i would recommend writing something about the changed status codes. So monitoring doesn't break if you think that would be a possibility.
johanib
force-pushed
the
feature/EB-1758_declutter-error-handler
branch
from
edf1931 to
5c9e561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, there were many 'empty' identical twig templates in the error process. This change replaces them with a 'generic-error' twig template.
Resolves #1758