Open
Conversation
tvdijen
force-pushed
the
feature/configurable-metadata-translations
branch
15 times, most recently
from
2fba06d to
1caa10e
Compare
Contributor
Author
|
@MKodde Would you please help me fix the last few unit tests? 🙎🏻♂️ I'm stuck and this close to going |
tvdijen
force-pushed
the
feature/configurable-metadata-translations
branch
from
1caa10e to
e8bf462
Compare
Member
|
@tvdijen I think I fixed the unit tests. You where on the right track, but needed some additional translations for the different configured languages (en/nl/pt). Now 🤞 the other tests pass. I also took the liberty to squash the commits, as they are really one atomic whole. But the main reason is to steal (co-author) this commit from you ;) |
MKodde
force-pushed
the
feature/configurable-metadata-translations
branch
from
51a7a38 to
8c0383e
Compare
MKodde
pushed a commit
to tvdijen/OpenConext-engineblock
that referenced
this pull request
Aug 27, 2024
This is a continuation of OpenConext#1103 where we made the Organization-data in metadata configurable using the translations-files. However, the result would be like this: <md:OrganizationDisplayName lang="en">My fictional organization</md:OrganizationDisplayName> <md:OrganizationDisplayName lang="nl">My fictional organization</md:OrganizationDisplayName> Instead of: <md:OrganizationDisplayName lang="en">My fictional organization</md:OrganizationDisplayName> <md:OrganizationDisplayName lang="nl">Mijn fictieve organisatie</md:OrganizationDisplayName> Everything was being translated using the default locale. This PR attempts to fix that. See: OpenConext#1292 See: OpenConext#1103
MKodde
force-pushed
the
feature/configurable-metadata-translations
branch
from
8c0383e to
0bb2a4e
Compare
MKodde
reviewed
Aug 27, 2024
src/OpenConext/EngineBlock/Metadata/Factory/ValueObject/EngineBlockConfiguration.php
Show resolved
Hide resolved
baszoetekouw
requested review from
johanib and
kayjoosten
and removed request for
thijskh
Contributor
|
@tvdijen can you rebase the pr? ill test it after and if it works ill approve it :D |
Contributor
I'll rebase it if needed. Need to dive in anyway. |
Contributor
Author
|
I'm sorry, I'm not going over this struggle again after this PR aged like milk for two years. |
This is a continuation of OpenConext#1103 where we made the Organization-data in metadata configurable using the translations-files. However, the result would be like this: <md:OrganizationDisplayName lang="en">My fictional organization</md:OrganizationDisplayName> <md:OrganizationDisplayName lang="nl">My fictional organization</md:OrganizationDisplayName> Instead of: <md:OrganizationDisplayName lang="en">My fictional organization</md:OrganizationDisplayName> <md:OrganizationDisplayName lang="nl">Mijn fictieve organisatie</md:OrganizationDisplayName> Everything was being translated using the default locale. This PR attempts to fix that. See: OpenConext#1292 See: OpenConext#1103
After storing organization translation keys instead of translated values
in EngineBlockConfiguration, contact persons were inadvertently using the
raw key string ('metadata_organization_name') as their GivenName rather
than the actual translated value.
ContactPerson elements in SAML metadata have no locale support, so the
translation is resolved once at construction time using the default locale.
kayjoosten
force-pushed
the
feature/configurable-metadata-translations
branch
from
bb87c8e to
9a56b01
Compare
Contributor
visual representation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1103 where we made the Organization-data in metadata configurable using the translations-files.
However, the result would be like this:
Instead of:
Everything was being translated using the default locale. This PR attempts to fix that.