Add listener to the modal to close it when the user clicks on the close button#445
Open
gregmelo wants to merge 25 commits intoOpenClassrooms-Student-Center:masterfrom
Open
Add listener to the modal to close it when the user clicks on the close button#445gregmelo wants to merge 25 commits intoOpenClassrooms-Student-Center:masterfrom
gregmelo wants to merge 25 commits intoOpenClassrooms-Student-Center:masterfrom
Conversation
Suppression de la fermeture d'une div en trop à la ligne 33.
Suppression du doublon de l'attribut class dans le bouton submit à la ligne 209.
Correction du texte à la ligne 201.
Déplacement des attributs width et height de la balise img vers le fichier CSS à la ligne 20.
Ajout de l'attribut required à la balise input à la ligne 191 plutôt que sur le label.
le prénom, le mail, la date de naissance et le nbr de tournois joués.
+ addition of error messages for each checked field. Issues#3
of the confirmation message once the form is submitted
… the modal.js file, switch from French to English.
addition of comments in the HTML file, and addition of closing the menu if you click on the "I register" button.
update of index.html file + update readme
the closing of the menu when the modal is open in the mobile version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.