[Connectors-SDK] Handle config deprecation and migration in connectors-sdk#5563
Merged
[Connectors-SDK] Handle config deprecation and migration in connectors-sdk#5563
Conversation
a35f198 to
34b8e57
Compare
2c3ae0e to
f036472
Compare
f036472 to
47a794e
Compare
jabesq
requested changes
Feb 6, 2026
Powlinett
reviewed
Feb 18, 2026
Member
Powlinett
left a comment
There was a problem hiding this comment.
Thank you so much for this great contribution @throuxel 🤘
I don't approve the PR right now to leave room for discussion, but as far as I tested it works as expected ✅️
Most of my comments are about naming things and it's obviously debatable.
Plus, I noticed 10 new warnings emitted while running tests, and I couldn't find the actual cause:
tests/test_settings/test_base_settings.py: 8 warnings
tests/test_settings/test_deprecation_migration.py: 2 warnings
~/code/filigran/connectors/connectors-sdk/venv/lib/python3.12/site-packages/pydantic_settings/main.py:447: UserWarning: Config key `yaml_file` is set in model_config but will be ignored because no YamlConfigSettingsSource source is configured. To use this config key, add a YamlConfigSettingsSource source to the settings sources via the settings_customise_sources hook.
cls._settings_warn_unused_config_keys(sources, cls.model_config)
Do you have any idea of what's happening?
Thanks again, well done 💪
47a794e to
783796d
Compare
Member
|
LGTM 👏 let us know when you're ready for merge 😇 |
783796d to
a947930
Compare
a947930 to
141d051
Compare
Powlinett
approved these changes
Feb 24, 2026
jabesq
pushed a commit
that referenced
this pull request
Feb 25, 2026
mitchm101
pushed a commit
to team-cymru/opencti-connectors
that referenced
this pull request
Mar 26, 2026
semayellow
pushed a commit
to semayellow/OpenCTI-integration
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a deprecation handling system for the connectors SDK, managing automatically different use-cases while maintaining backward compatibility.
Exemple:
Related issues
Checklist
Further comments
The dummy connector is only for demo, and should be removed before merging.