Fix CloudKit reaction parent parsing and round-trip encoding - #239
Draft
Xare123 wants to merge 1 commit into
Draft
Fix CloudKit reaction parent parsing and round-trip encoding#239Xare123 wants to merge 1 commit into
Xare123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Downloaded reactions could retain Apple parent wrappers instead of the message GUID, partless uploads could emit
p:null/<guid>, newer reaction types could throw, and attachment GUID parsing could truncate identifiers containing underscores.Change
Normalize bare,
p:, andbp:parent references; encode partless parents without a null wrapper; bound reaction-type mapping; and preserve complete attachment GUIDs.Validation
Focused Flutter tests pass: 5/5 for accepted/rejected parent forms, partless round trips, reaction bounds, and attachment GUIDs.
Non-goals and safety
This is a narrow live/legacy correctness fix. It does not enable Cloud Sync V2, alter checkpoints, delete remote or local records, or add storage schemas.