Conversation
7d7af72 to
8dabe75
Compare
86a0caa to
5fb53e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two further modifications for ring-breaking perutrbations:
Linear spacer modification for ring-breaking ghost bridges
When a ghost atom bridges exactly two physical atoms (the P1–G–P2 topology that arises when a ring is broken), removing the P1–G–P2 angle entirely leaves the ghost free to collapse onto one of its physical neighbours. Instead, this change sets the P1–G–P2 angle to 180° with a soft force constant (k_soft), turning the ghost into a linear spacer sitting midway between the two physical atoms. The ghost bond force constants to P1 and P2 are also softened, with equilibrium lengths set to half the physical end-state P1–P2 distance so the ghost sits at the midpoint at zero bond energy. All dihedrals involving the ghost are removed as they are degenerate at 180°. The modification is skipped if the ghost is a chiral centre.
Removal of cross-bond angles in end-state where bond is absent
For ring-making/breaking perturbations, angles that span the changing bond are parameterised for the bonded geometry. In the end state where the bond is absent, these angles constrain the two atoms toward each other even without a bond between them, producing large LJ repulsion at the nonbonded/bonded lambda boundary and causing poor overlap between adjacent lambda windows. This change detects ring-making and ring-breaking bonds by comparing the end-state connectivities, then removes any angle term spanning those bonds in the state where the bond does not exist: ring-making bonds lose their spanning angles from angle0, ring-breaking bonds from angle1.