feat(agent): add filesystem-backed Agent Skills support to agent nodes#559
feat(agent): add filesystem-backed Agent Skills support to agent nodes#559zivkovicp wants to merge 2 commits intoOpenBMB:mainfrom
Conversation
NA-Wen
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution — this feature is quite important for the project and we really appreciate the effort you put into it 🥳.
That said, the addition of python_execution here does not seem strictly necessary. Could you please revisit this part and consider removing or simplifying it if it is not that necessary?
Once this part is updated, we will merge the PR as soon as possible ! Thanks again for your vital contribution !
|
I made the requested change and pushed to my branch. It seems the PR is slow to sync, if the changes aren't visible in a reasonable amount of time, please advise on how to update this PR (I'm not a regular GitHub contributor and am not familiar) |
|
Thanks for the fast follow-up here and for iterating on this so quickly after our previous discussion. This is a meaningful contribution overall: the skill abstraction is clean, the config surface is easy to understand, and the built-in The implementation does not track the most recently activated skill as the current active skill. In runtime/node/agent/skills/manager.py#L172, This causes incorrect behavior when the model activates multiple skills in sequence. For example:
Semantically, I also verified this locally: after activating I think this should be modeled as explicit “current active skill” state, rather than inferring it from a set of previously activated skills. |
Summary
skills/directory