fix: isolate Capture codec fixture in adapter tests#234
Merged
Conversation
abrichr
marked this pull request as ready for review
July 24, 2026 01:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deterministic, lossless test-only writer/extractor boundary
CaptureSessionaction processing and public frame lookup, the Flow conversion bridge, and
the unmodified compiler
openadapt-capture, where theexternal FFmpeg contract is owned
Root cause
Flow v1.20.1 qualification resolved
openadapt-capture==1.0.2. Afteropenadapt-capture==1.0.3published, release-commit CI re-resolved the floatingcaptureextra and all Capture adapter cases failed closed withFFmpegUnavailableError. Capture 1.0.4 also changes the implementation todirect
subprocess.Popenstreaming with MP4 timing metadata, so emulatingprivate FFmpeg commands would be brittle.
This fix patches only this test module's
VideoWritername and Capture's publicopenadapt_capture.video.extract_frameseam. It does not patch_run_checked,subprocess.Popen, concat/PNG commands, MP4 UUID internals, or any productionpath.
Safety / production impact
Verification
ruff check tests/test_capture_adapter.pyruff format --check tests/test_capture_adapter.pypytest -q --timeout=300 tests/test_capture_adapter.py— 34 passed againstexact Capture main
c11969b7efd2eaaf9981d853fbe62d2bdaddd953(direct Popen/UUID implementation)
openadapt-capture==1.0.4wheelopenadapt-capture==1.0.3wheel