fix(capture): align malformed window marker error#154
Merged
Conversation
abrichr
force-pushed
the
agent/capture-window-marker-message-20260718
branch
from
July 19, 2026 04:09
fd7a100 to
685fd67
Compare
Member
Author
|
Post-v1.17.1 queue preparation (2026-07-19)
This remains draft and unmerged. Queue order is intentionally:
No publication or production mutation is being performed from this PR yet. |
abrichr
marked this pull request as ready for review
July 19, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Align the fallback
capture_windowvalidation error with the existingfail-closed regression contract:
capture_windowfield name for diagnosis; andWhy
PR #146 added both the fail-closed validation and its optional-capture
regression, but the fallback branch used a different phrase than the test
contract. With
openadapt-captureinstalled, the behavior was correct and thetest failed only because the error message did not match.
Impact
No capability, gate, or execution behavior changes. Malformed metadata still
halts conversion rather than falling back to unsafe full-screen scaling.
Verification
_window_capture_metaregression: malformed fallback metadata raisesValueErrorcontaining bothmalformed window-capture metadataandcapture_window;git diff --checkpasses.The full optional-capture test module was not rerun on the local headless macOS
session because the separately installed capture checkout attempts a real
screen probe during import. Protected CI remains the definitive clean
environment gate.