Capture Windows UIA evidence with native actions#45
Merged
Conversation
abrichr
marked this pull request as ready for review
July 25, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
openadapt.capture.structural-observation/v1schema and injectable read-only observer protocol.ActionEventinrecording.dband exposes it through raw events and processedCaptureSession.actions().Independent review fixes
Review against pywinauto 0.6.9 found that the first draft's fakes were more permissive than the real API. The updated branch now:
POINTABI beforeDesktop.from_point;IUIA().get_focused_element()andUIAElementInfo, rather than the nonexistentDesktop.get_active();auto_idfilter todescendants();The tests now mirror those exact API shapes and verify lifecycle start/event/stop all execute on the same delivery thread.
Why
openadapt-captureis the canonical native demonstration recorder. Native Windows authoring needs live structural evidence beside pixels and input timing soopenadapt-flowcan normalize and compile stronger structural bindings without rebuilding capture in the engine.Dependency and package boundary
pywinauto>=0.6.9is a Windows-only conditional dependency and is loaded lazily only on the Windows input-delivery thread. PyPI identifies 0.6.9 as BSD 3-clause. It is not vendored or bundled into these source archives.The built wheel and sdist both passed
scripts/verify_distribution.py, include the MIT license plus the new schema/observer modules, and contain no OpenIMIS, AGPL, real-EMR, or private-corpus payload matches.Validation
ruff check openadapt_capture tests/test_structural_observation.py tests/test_input_observer.pypytest -q tests/ --ignore=tests/test_browser_bridge.py -m 'not slow'→ 333 passed, 8 deselectedArtifact SHA-256:
eff076c5bcf4c214e57eca0e572bd3a4cab88b07141514859306097ed23f5ec0a289ad94c92f981cac0fd2d33371efb023ad17e1da85f96788350c4c8b66ec61Follow-up boundary
This draft intentionally stops at the capture-side contract. Flow normalization/compiler changes belong in a separate PR.