Fix numeric enum deserialization#24394
Open
sakshichitnis27 wants to merge 3 commits into
Open
Conversation
Signed-off-by: sakshichitnis27 <sakshichitnis27@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Member
|
thanks for the PR cc @devhl-labs |
Member
|
please follow step 3 to update the samples |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24344
Description
Makes numeric inner-enum deserialization consistent with string enums in the C#
generichostgenerator.null.Validation
CSharpClientCodegenTest: 10 tests passed, 0 failures.null.git diff --checkpassed.PR checklist
Summary by cubic
Fix numeric enum deserialization in the C#
generichostgenerator to match string enums. Unknown numeric values now become null for nullable enums and are skipped for non‑nullable enums (including byte‑backed); parsing is centralized inNumericInnerEnumJsonRead.mustache, with tests covering nullable inline int enums.Written for commit ab54d9a. Summary will update on new commits.