Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 23, 2026

to close #22778

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Bumped Logback to 1.5.25 across Java JAX-RS generator templates and sample projects. Keeps logging dependencies current and consistent for CXF and Jersey builds.

  • Dependencies
    • Updated logback-version from 1.5.19 to 1.5.25 in JAX-RS pom.mustache files (cxf, cxf-ext, server, jersey2/3).
    • Updated petstore sample poms (clients and servers) to use Logback 1.5.25.

Written for commit ed12f3a. Summary will update on new commits.

@wing328 wing328 added this to the 7.20.0 milestone Jan 23, 2026
@wing328 wing328 changed the title update logback to newer version Update logback to newer version Jan 23, 2026
@wing328 wing328 marked this pull request as ready for review January 23, 2026 07:55
@wing328 wing328 merged commit 8a3507c into master Jan 23, 2026
173 checks passed
@wing328 wing328 deleted the update-jaxrs-cxf-client branch January 23, 2026 07:55
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 17 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="samples/server/petstore/jaxrs-jersey/pom.xml">

<violation number="1" location="samples/server/petstore/jaxrs-jersey/pom.xml:212">
P1: Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.</violation>
</file>

<file name="samples/server/petstore/jaxrs-datelib-j8/pom.xml">

<violation number="1" location="samples/server/petstore/jaxrs-datelib-j8/pom.xml:212">
P1: Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

<jackson-version>2.17.1</jackson-version>
<junit-version>4.13.2</junit-version>
<logback-version>1.5.19</logback-version>
<logback-version>1.5.25</logback-version>
Copy link

@cubic-dev-ai cubic-dev-ai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/jaxrs-jersey/pom.xml, line 212:

<comment>Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.</comment>

<file context>
@@ -209,7 +209,7 @@ for this project used jakarta.validation-api -->
     <jackson-version>2.17.1</jackson-version>
     <junit-version>4.13.2</junit-version>
-    <logback-version>1.5.19</logback-version>
+    <logback-version>1.5.25</logback-version>
     <servlet-api-version>4.0.4</servlet-api-version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</file context>
Suggested change
<logback-version>1.5.25</logback-version>
<logback-version>1.3.16</logback-version>
Fix with Cubic

<jackson-version>2.17.1</jackson-version>
<junit-version>4.13.2</junit-version>
<logback-version>1.5.19</logback-version>
<logback-version>1.5.25</logback-version>
Copy link

@cubic-dev-ai cubic-dev-ai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/jaxrs-datelib-j8/pom.xml, line 212:

<comment>Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.</comment>

<file context>
@@ -209,7 +209,7 @@ for this project used jakarta.validation-api -->
     <jackson-version>2.17.1</jackson-version>
     <junit-version>4.13.2</junit-version>
-    <logback-version>1.5.19</logback-version>
+    <logback-version>1.5.25</logback-version>
     <servlet-api-version>4.0.4</servlet-api-version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</file context>
Suggested change
<logback-version>1.5.25</logback-version>
<logback-version>1.3.16</logback-version>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants