-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Update logback to newer version #22781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 17 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/server/petstore/jaxrs-jersey/pom.xml">
<violation number="1" location="samples/server/petstore/jaxrs-jersey/pom.xml:212">
P1: Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.</violation>
</file>
<file name="samples/server/petstore/jaxrs-datelib-j8/pom.xml">
<violation number="1" location="samples/server/petstore/jaxrs-datelib-j8/pom.xml:212">
P1: Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| <jackson-version>2.17.1</jackson-version> | ||
| <junit-version>4.13.2</junit-version> | ||
| <logback-version>1.5.19</logback-version> | ||
| <logback-version>1.5.25</logback-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/jaxrs-jersey/pom.xml, line 212:
<comment>Logback 1.5.25 requires JDK 11 at runtime, but this project declares Java 8. This version bump will break runtime compatibility for the sample unless the Java target is raised or logback is downgraded to a Java 8-compatible line.</comment>
<file context>
@@ -209,7 +209,7 @@ for this project used jakarta.validation-api -->
<jackson-version>2.17.1</jackson-version>
<junit-version>4.13.2</junit-version>
- <logback-version>1.5.19</logback-version>
+ <logback-version>1.5.25</logback-version>
<servlet-api-version>4.0.4</servlet-api-version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</file context>
| <logback-version>1.5.25</logback-version> | |
| <logback-version>1.3.16</logback-version> |
| <jackson-version>2.17.1</jackson-version> | ||
| <junit-version>4.13.2</junit-version> | ||
| <logback-version>1.5.19</logback-version> | ||
| <logback-version>1.5.25</logback-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/jaxrs-datelib-j8/pom.xml, line 212:
<comment>Logback 1.5.x requires JDK 11, but this sample targets Java 8; upgrading to 1.5.25 will be incompatible. Use a Java 8–compatible Logback line or raise the Java version.</comment>
<file context>
@@ -209,7 +209,7 @@ for this project used jakarta.validation-api -->
<jackson-version>2.17.1</jackson-version>
<junit-version>4.13.2</junit-version>
- <logback-version>1.5.19</logback-version>
+ <logback-version>1.5.25</logback-version>
<servlet-api-version>4.0.4</servlet-api-version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</file context>
| <logback-version>1.5.25</logback-version> | |
| <logback-version>1.3.16</logback-version> |
to close #22778
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Bumped Logback to 1.5.25 across Java JAX-RS generator templates and sample projects. Keeps logging dependencies current and consistent for CXF and Jersey builds.
Written for commit ed12f3a. Summary will update on new commits.