feat: add i18n support with zh-Hant and zh-CN translations

[Jacky97s]

Summary

• Add I18n utility class with UTF-8 ResourceBundle loading and locale parsing
• Extract all user-facing strings from renderers (Console, Markdown, HTML, AsciiDoc) into .properties resource bundles
• Add --lang CLI option to select output language (en, zh-Hant, zh-CN)
• Add CJK-aware display width calculation for correct console alignment with Chinese characters
• Add Traditional Chinese (zh-TW) and Simplified Chinese (zh-CN) translation files
• Set HTML lang attribute dynamically based on locale

Usage

# Default (English)
openapi-diff old.yaml new.yaml

# Traditional Chinese
openapi-diff old.yaml new.yaml --lang zh-Hant

# Simplified Chinese
openapi-diff old.yaml new.yaml --lang zh-CN

Test plan

• All 266 existing tests pass with default English locale
• Verify console output alignment with Chinese characters
• Verify HTML output includes correct lang attribute for each locale
• Verify --lang CLI option selects correct translations

---

Summary by cubic

Add internationalization across renderers and the CLI with English, Traditional Chinese (zh-Hant), and Simplified Chinese (zh-CN). Adds a --lang option, CJK-aware console alignment, per-locale HTML lang, and hardens i18n with thread-safe and null-safe handling.

• New Features

  • Introduced I18n utility with UTF-8 ResourceBundle loading and locale parsing.
  • Replaced hardcoded strings in Console/Markdown/HTML/AsciiDoc with bundle messages.
  • Added translations: messages.properties (en), messages_zh_TW.properties (zh-Hant), messages_zh_CN.properties (zh-CN).
  • Added --lang CLI option (en, zh-Hant, zh-CN), accepts zh-TW/zh-Hans aliases.
  • Implemented CJK-aware display width for proper console alignment.
  • HTML output now sets the lang attribute based on the selected locale.

• Bug Fixes

  • Prevented NPEs by adding null checks to CJK centering helpers.
  • Made I18n locale and bundle handling thread-safe (volatile fields, synchronized setLocale).

^{Written for commit da71782. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="core/src/main/java/org/openapitools/openapidiff/core/output/ConsoleRender.java">

<violation number="1" location="core/src/main/java/org/openapitools/openapidiff/core/output/ConsoleRender.java:362">
P2: New CJK centering helper is not null-safe and can throw NPE during rendering/formatting.</violation>
</file>

<file name="core/src/main/java/org/openapitools/openapidiff/core/output/I18n.java">

<violation number="1" location="core/src/main/java/org/openapitools/openapidiff/core/output/I18n.java:20">
P2: `I18n` uses unsynchronized mutable static locale/bundle state, which is not thread-safe and can leak or mismatch language state across concurrent operations.</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
• Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Jacky97s]

@cubic-dev-ai

review again

[cubic-dev-ai]

@cubic-dev-ai

review again

@Jacky97s I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 10 files