chore(pyoaev): compatibility support Python 3.14 (#337) - #339
chore(pyoaev): compatibility support Python 3.14 (#337)#339Ferdinand (guzmud) wants to merge 1 commit into
Conversation
|
🤖 [AI-generated] Hey Ferdinand (@guzmud)! 👋 Thanks a lot for opening PR #339 — really appreciate the contribution, especially getting ahead of Python 3.14 compatibility! 🙏 I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle suggestion:
No rush at all — thanks again for contributing to the project! 🚀 |
There was a problem hiding this comment.
Pull request overview
Updates pyoaev’s manager auto-creation logic to stay compatible with Python 3.14’s annotation handling changes by switching to the supported introspection API (typing.get_type_hints) instead of relying on instance __annotations__.
Changes:
- Import
get_type_hintsfromtyping. - Use
get_type_hints(type(self))to retrieve annotations when creating managers.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| annotations = get_type_hints(type(self)) | ||
| for attr, annotation in sorted(annotations.items()): |
Proposed changes
get_type_hints(type(self))instead ofself.__annotations__to maintain compatibility with the new annotation handling introduced in Python 3.14 and to use the introspection API recommended by Python.Testing Instructions
Related issues
Checklist
Further comments