Add debugger device-settings support to cbuild-run generation#2514
Add debugger device-settings support to cbuild-run generation#2514brondani wants to merge 6 commits into
device-settings support to cbuild-run generation#2514Conversation
device-settings support to cbuild-run generation
Test Results 2 files - 32 14 suites - 68 13m 33s ⏱️ - 1m 0s Results for commit 4f6a6aa. ± Comparison against base commit e8e6d1e. This pull request removes 266 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
@grasci-arm Please review this PR |
|
Thanks for the ping. I’ll review the PR and get back with comments if I find anything. |
grasci-arm
left a comment
There was a problem hiding this comment.
The new device-settings plumbing is broadly coherent, but I found one serious regression risk: dbgconf parsing now silently ignores any final assignment lacking a semicolon and will drop the entire file’s last setting, which can break generated debugger behavior for valid-but-minimal dbgconf content.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
==========================================
+ Coverage 65.29% 65.34% +0.05%
==========================================
Files 147 147
Lines 26702 26774 +72
Branches 16184 16219 +35
==========================================
+ Hits 17435 17496 +61
- Misses 7070 7072 +2
- Partials 2197 2206 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thanks for the ping — I’ve reviewed the PR and the new A couple of things stand out as good to keep in mind:
Overall, the change looks good to me. |
|
Thanks for the ping — I’ll review this PR. |
Fixes
device-settings:cmsis-toolbox#636Changes
device-settingsto debugger parsing, schema validation, context processing, andcbuild-run.ymloutput..dbgconfvariable assignments when explicitdevice-settingsare not provided.ParseDbgconfFileutility coverage and updated run-debug reference outputs/test data.Risk / Limitations
.dbgconfparsing is limited to simple semicolon-terminated assignments after stripping C-style comments.Checklist