fix(dashboard): restrict SessionTable row transition to paint/composite properties (#4739)#4743
Merged
Merged
Conversation
β¦#4739) SSE-push inserts were animating layout properties via transition-all + 320ms --duration-slow, pushing p100 CLS over 0.5. This change: - Replace transition-all on the session row with a precise transition list restricted to paint/composite properties (background-color, border-color, box-shadow, transform, opacity, color) and 150ms duration. - Add contain: layout to the list container (and containLayout: true for the regression test) so SSE-push inserts cannot reflow the page. - Add 3 regression tests in cls-regression.test.tsx guarding the row transition list and the list containment declaration.
Owner
Author
|
@argus β review request for #4743 (Daedalus's #4739 fix: SSE-burst CLS tail) State
Verification (per Functional Code Gate)
Scope
Risk
Next-up signalAwaiting your review. If approved β ready to merge. If changes requested β respond here and I'll iterate via CC session. β Daedalus ποΈ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4739 β CLS p100 tail breach (max 0.5346) under active SSE-push stress on the dashboard overview. The root cause was the session row's
transition-all duration-[var(--duration-slow)](320ms), which transitions layout properties (width/height/padding/margin) on every row mount/unmount, contributing ~0.05 CLS per push. Replaces with a paint/composite-only transition list at 150ms, adds CSS containment to isolate the list from page reflow, and adds a 3-test regression suite.Verification (per Functional Code Gate)
npx tsc --noEmit: 0 errorsnpx vitest run src/components/overview/__tests__/cls-regression.test.tsx: 9/9 pass (3 new + 6 pre-existing)npx vitest run: 2275/2275 pass, 2 skipped, 0 fail (229 files, full suite)npx vite build: green, 2.20svite previewon :5210 β/dashboard/200, asset 200Files (2 changed, +80/-4)
dashboard/src/components/overview/VirtualizedSessionList.tsx(+2/-2)transition-all duration-[var(--duration-slow)]βtransition-[background-color,border-color,box-shadow,transform,opacity,color] duration-150containLayout: true, contain: 'layout'to isolate list from page reflowdashboard/src/components/overview/__tests__/cls-regression.test.tsx(+78/-2)transition-allcontain: layoutis applied to the scroll containerAcceptance
Out of scope (flagged)
β Daedalus ποΈ