Skip to content

feat: add Huawei and email_reply_to_address parameters to Notification#80

Merged
sherwinski merged 1 commit intomainfrom
user-api-updates
Mar 24, 2026
Merged

feat: add Huawei and email_reply_to_address parameters to Notification#80
sherwinski merged 1 commit intomainfrom
user-api-updates

Conversation

@onesignal-deploy
Copy link
Collaborator

@onesignal-deploy onesignal-deploy commented Jan 29, 2026 •
edited by sherwinski
Loading

Features

Adds the following Notification parameters:

  • huawei_badge_class
  • huawei_badge_add_num
  • huawei_badge_set_num
  • huawei_category
  • huawei_bi_tag
  • email_reply_to_address

@onesignal-deploy onesignal-deploy force-pushed the user-api-updates branch 2 times, most recently from 8d3a5fb to 826f752 Compare February 2, 2026 19:13
@sherwinski sherwinski changed the title Add v5.4.0-beta1 package updates Add v5.4.0 package updates Mar 24, 2026
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2026
View reviewed changes
.github/workflows/release.yml
Comment on lines +45 to +61
name: Publish to NuGet
needs: release
if: needs.release.outputs.new_release_published == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- name: Setup dotnet
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.x
- name: Build and Pack
run: |
dotnet restore
dotnet build --configuration Release --no-restore
dotnet pack src/OneSignalApi/OneSignalApi.csproj --configuration Release --no-build --output nupkgs
- name: Publish to NuGet
run: dotnet nuget push nupkgs/*.nupkg --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 3 days ago

In general, the fix is to add an explicit permissions block either at the workflow root (applying to all jobs) or specifically on jobs that currently rely on default GITHUB_TOKEN permissions. Here, the release job already has a correctly scoped permissions block; only the publish job is missing one.

The best targeted fix without changing functionality is to add a permissions block to the publish job that grants only contents: read. This is sufficient, since publish needs only to check out code and then interact with NuGet using secrets.NUGET_API_KEY, not modify anything in the GitHub repository. Concretely, in .github/workflows/release.yml, under jobs:, inside the publish: job definition (around line 45), insert:

    permissions:
      contents: read

right after runs-on: ubuntu-latest (or equivalently near the top of the job’s keys). No imports or additional methods are required, as this is purely a YAML configuration change in the workflow file.

Suggested changeset 1
.github/workflows/release.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -46,6 +46,8 @@
     needs: release
     if: needs.release.outputs.new_release_published == 'true'
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
       - uses: actions/checkout@v5
       - name: Setup dotnet
EOF
@@ -46,6 +46,8 @@
needs: release
if: needs.release.outputs.new_release_published == 'true'
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v5
- name: Setup dotnet
Copilot is powered by AI and may make mistakes. Always verify output.
@sherwinski sherwinski changed the title Add v5.4.0 package updates feat: add Huawei and email_reply_to_address parameters to Notification Mar 24, 2026
@sherwinski sherwinski changed the title feat: add Huawei and email_reply_to_address parameters to Notification Add v5.4.0 package updates Mar 24, 2026
@sherwinski sherwinski changed the title Add v5.4.0 package updates feat: add Huawei and email_reply_to_address parameters to Notification Mar 24, 2026
@sherwinski sherwinski merged commit 205cefb into main Mar 24, 2026
3 checks passed
@sherwinski sherwinski deleted the user-api-updates branch March 24, 2026 19:04
github-actions bot pushed a commit that referenced this pull request Mar 24, 2026
@semantic-release-bot
chore(release): 5.4.0
887defe 
## [5.4.0](v5.3.0...v5.4.0) (2026-03-24)

### Features

* add Huawei and email_reply_to_address parameters to Notification ([#80](#80)) ([205cefb](205cefb))
 [skip ci]
@github-actions
Copy link

github-actions bot commented Mar 24, 2026

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sherwinski sherwinski sherwinski approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onesignal-deploy @sherwinski