fix: [SDK-5065] report unbuildable log requests as a permanent failure - #1727
Merged
Conversation
The -1 transport sentinel was returned both when a request got no usable response and when the URL could not be constructed at all. The shared retry policy in the KMP logger classifies -1 as transient, so a malformed base URL or app id would burn the full retry budget and its backoff on every batch, indefinitely, against a misconfiguration that cannot resolve itself. Reports -3 for the unbuildable case instead. The shared policy already treats anything it does not recognise as permanent, so this needs no coordinated change; the KMP side documents the distinction and pins it with a test. No behavioural change until the export-retry work lands — before it, every failure was single-shot regardless of code. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: [SDK-5065] report unbuildable log requests as a permanent failure
The -1 transport sentinel was returned both when a request got no usable
response and when the URL could not be constructed at all. The shared retry
policy in the KMP logger classifies -1 as transient, so a malformed base URL or
app id would burn the full retry budget and its backoff on every batch,
indefinitely, against a misconfiguration that cannot resolve itself.
Reports -3 for the unbuildable case instead. The shared policy already treats
anything it does not recognise as permanent, so this needs no coordinated
change; the KMP side documents the distinction and pins it with a test.
No behavioural change until the export-retry work lands — before it, every
failure was single-shot regardless of code.
Companion to OneSignal-KMP-SDK#21, which adds the retry policy that makes this distinction matter. Independent of #1725 — it touches only the HTTP sender and needs no submodule bump.
Testing
OneSignalOSCorebuilds clean for iphonesimulator against the current submodule pin.Made with Cursor