chore: [SDK-5084] remove unsupported iOS compatibility code - #1726
Open
fadi-george wants to merge 4 commits into
Open
chore: [SDK-5084] remove unsupported iOS compatibility code#1726fadi-george wants to merge 4 commits into
fadi-george wants to merge 4 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove obsolete compatibility paths for iOS versions below the SDK's iOS 12 minimum.
Details
Motivation
The SDK no longer supports iOS versions below 12, leaving runtime checks, fallbacks, constants, tests, and comments that cannot apply to supported devices.
Scope
Other
Multi-model review completed. Compatibility and older-Xcode findings were addressed before opening this PR.
Testing
Unit testing
No new tests were needed because the removed branches cannot execute on supported iOS versions. Obsolete commented tests for unsupported versions were removed.
Manual testing
UnitTestApptest bundle for an iOS simulator.UnitTestApp_TestPlan_Reducedsuccessfully on an iOS simulator.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor