chore: [SDK-5068] raise minimum iOS version to 12 - #1724
Merged
Conversation
nan-li
approved these changes
Aug 25, 2026
nan-li
left a comment
Contributor
There was a problem hiding this comment.
LGTM, we also have dead code in the SDK, can be a backlogged ticket to clean those up too
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Tracked the dead-code cleanup in SDK-5084. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Raise the OneSignal iOS SDK minimum supported deployment target from iOS 11 to iOS 12.
Details
Motivation
Align the SDK's package metadata, Xcode targets, and support tooling with the documented iOS 12 minimum.
Scope
Updates Swift Package Manager, CocoaPods, SDK and development-app Xcode deployment targets, and the GitHub bug report template. No runtime behavior or public APIs change.
Other
Multi-model review completed with no blocking findings.
Testing
Unit testing
No unit tests were added because this change only updates deployment and package configuration.
Manual testing
swift package dump-packageplutilandxcodebuild -listvalidation for both Xcode projectsOneSignalCorescheme for a generic iOS Simulator destinationThe targeted build passed with existing compiler deprecation and null-conversion warnings. Full CI will run on this PR. Device testing is not applicable to a configuration-only change.
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor