Skip to content

fix: [SDK-4190] PermissionsActivity does not follow app theme #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fadi-george wants to merge 3 commits into
base: 5.7-main
Choose a base branch
from
Open

fix: [SDK-4190] PermissionsActivity does not follow app theme #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52e4248
chore(demo): enable edge-to-edge display in demo app
fadi-george Mar 19, 2026
b012bd0
fix: [SDK-4190] PermissionsActivity does not follow app theme
fadi-george Mar 19, 2026
fd891cc
ci: add Linear ticket automation workflow
fadi-george Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/linear-deployed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Move Linear tickets to Deployed

on:
release:
types: [published, edited]

jobs:
linear-deployed:
uses: OneSignal/sdk-shared/.github/workflows/linear-deployed.yml@main
with:
release_body: ${{ github.event.release.body }}
secrets:
LINEAR_GITHUB_API_KEY: ${{ secrets.LINEAR_GITHUB_API_KEY }}
2 changes: 1 addition & 1 deletion OneSignalSDK/onesignal/core/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</service>

<activity android:name="com.onesignal.core.activities.PermissionsActivity"
android:theme="@android:style/Theme.Translucent.NoTitleBar"
android:theme="@style/OneSignal.Theme.Translucent"
android:exported="false" />
</application>

Expand Down
9 changes: 9 additions & 0 deletions OneSignalSDK/onesignal/core/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="OneSignal.Theme.Translucent" parent="@android:style/Theme.Translucent.NoTitleBar">
<item name="android:windowBackground">@android:color/transparent</item>
<item name="android:windowDrawsSystemBarBackgrounds">true</item>
<item name="android:statusBarColor">@android:color/transparent</item>
<item name="android:navigationBarColor">@android:color/transparent</item>
</style>
</resources>
12 changes: 11 additions & 1 deletion examples/demo/app/src/main/java/com/onesignal/sdktest/ui/main/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ package com.onesignal.sdktest.ui.main
import android.os.Bundle
import android.widget.Toast
import androidx.activity.ComponentActivity
import androidx.activity.SystemBarStyle
import androidx.activity.compose.setContent
import androidx.activity.enableEdgeToEdge
import androidx.activity.viewModels
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.material3.Surface
Expand All @@ -20,7 +22,15 @@ class MainActivity : ComponentActivity() {

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)


enableEdgeToEdge(
statusBarStyle = SystemBarStyle.dark(android.graphics.Color.TRANSPARENT),
navigationBarStyle = SystemBarStyle.light(
android.graphics.Color.TRANSPARENT,
android.graphics.Color.TRANSPARENT,
),
)

setContent {
OneSignalTheme {
Surface(
Expand Down
5 changes: 5 additions & 0 deletions examples/demo/app/src/main/java/com/onesignal/sdktest/ui/main/MainScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.navigationBars
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.windowInsetsBottomHeight
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.ExperimentalMaterial3Api
Expand Down Expand Up @@ -102,6 +105,7 @@ fun MainScreen(viewModel: MainViewModel) {

Box(modifier = Modifier.fillMaxSize()) {
Scaffold(
contentWindowInsets = WindowInsets(0, 0, 0, 0),
topBar = {
CenterAlignedTopAppBar(
title = {
Expand Down Expand Up @@ -274,6 +278,7 @@ fun MainScreen(viewModel: MainViewModel) {
)

Spacer(modifier = Modifier.height(24.dp))
Spacer(modifier = Modifier.windowInsetsBottomHeight(WindowInsets.navigationBars))
}
}
}
Expand Down
Loading