fix: add otel consumer R8 rule for optional jackson classes#2578
Closed
abdulraqeeb33 wants to merge 1 commit intomainfrom
Closed
fix: add otel consumer R8 rule for optional jackson classes#2578abdulraqeeb33 wants to merge 1 commit intomainfrom
abdulraqeeb33 wants to merge 1 commit intomainfrom
Conversation
Ship a consumer ProGuard suppression for optional Jackson core references from the OpenTelemetry exporter so downstream Android release builds do not fail with missing-class errors. Made-with: Cursor
Contributor
📊 Diff Coverage Report✓ Coverage check passed (no source files changed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add an OTEL consumer ProGuard rule to suppress optional Jackson core missing-class warnings so Android release builds with R8/Proguard succeed on 5.7.x.
Details
Motivation
Fixes the R8 missing class failure reported in #2576 where
io.opentelemetry.exporterreferences optionalcom.fasterxml.jackson.core.*classes not present on Android by default.Scope
otelmodule consumer ProGuard configuration.OPTIONAL - Other
Rule added in
OneSignalSDK/onesignal/otel/consumer-rules.pro:-dontwarn com.fasterxml.jackson.core.**Testing
Unit testing
No unit tests were needed because this is a consumer ProGuard metadata change.
Manual testing
./gradlew :OneSignal:otel:assemblesuccessfully.consumer-rules.prois packaged via existingconsumerProguardFilesconfig.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor