Skip to content

fix: skip ShortcutBadger on API 26+ to prevent SIGSEGV on Xiaomi devices #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fadi-george wants to merge 1 commit into
base: 5.7-main
Choose a base branch
from
Open

fix: skip ShortcutBadger on API 26+ to prevent SIGSEGV on Xiaomi devices #2570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...tions/src/main/java/com/onesignal/notifications/internal/badges/impl/BadgeCountUpdater.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ internal class BadgeCountUpdater(

override fun update() {
if (!areBadgesEnabled()) return
// On API 26+ the system handles badges via NotificationChannel, and
// ShortcutBadger can cause native SIGSEGV crashes on some OEM devices
// (e.g. Xiaomi Redmi) where the broadcast receiver has buggy native code.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) return
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
updateStandard()
} else {
Expand Down Expand Up @@ -83,6 +87,7 @@ internal class BadgeCountUpdater(

override fun updateCount(count: Int) {
if (!areBadgeSettingsEnabled()) return
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) return
try {
ShortcutBadger.applyCountOrThrow(_applicationService.appContext, count)
} catch (e: ShortcutBadgeException) {
Expand Down
Loading