feat(ci): publish snapshots and build docker images on every main push#134
Merged
Conversation
The release-please pipeline only published Maven artifacts and Docker images on a real release (`release_created == true`). Two gaps followed: - The release Docker build failed with "Username must not be null!" because docker-publish.yml never received the private OneLiteFeather Maven credentials needed to resolve `net.onelitefeather:vulpes-model`. Fixed upstream in OneLiteFeatherNET/workflows (>= v2.3.0); bump refs. - Snapshot versions (release-please's Java SNAPSHOT bumps, e.g. 2.0.1-SNAPSHOT) never triggered publish or docker, so build.gradle.kts' snapshot-repo routing was dead code. Add a `version` job that reads gradle.properties on non-release pushes and drives new `publish-snapshot` / `docker-snapshot` jobs whenever the version is a SNAPSHOT/BETA/ALPHA. Also add the `workflow_dispatch` trigger the docker job already referenced (manual image re-publish). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Test results 27 files 27 suites 3s ⏱️ Results for commit 2e607e8. ♻️ This comment has been updated with latest results. |
The shared docker-publish workflow no longer hardcodes the OneLiteFeather Maven secrets; it exposes a generic `build-env` input instead. Forward the credentials that way so the Gradle build inside the docker / docker- snapshot jobs can resolve the private vulpes-model dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
docker-publish.yml is now a pure, toolchain-agnostic Docker build. Move the Gradle step that generates the Micronaut optimized context into the new reusable gradle-docker-context.yml producer, which uploads the context as an artifact for docker-publish to consume. Both the release and snapshot paths now run: build-context* (Gradle) -> docker* (docker-publish via artifact-name) The producer carries the private Maven credentials (secrets: inherit), so the Docker job no longer needs them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release-please pipeline published Maven artifacts and Docker images only on a real release, and the release Docker build was broken: release
2.0.0(#129) failed because the Docker job couldn't resolve the privatenet.onelitefeather:vulpes-modeldependency (Username must not be null!). Snapshots (2.0.1-SNAPSHOT, …) never triggered publish or docker at all.Changes
versionjob readsgradle.propertieson non-release pushes;publish-snapshot+docker-snapshotrun on every non-release push when the version is SNAPSHOT/BETA/ALPHA. Maven publish auto-routes to the snapshot repo.gradle-docker-context.ymlproducer (carries the private Maven credentials viasecrets: inherit) and uploads the context as an artifact. The toolchain-agnosticdocker-publish.ymlconsumes it viaartifact-name. Both release and snapshot paths runbuild-context* → docker*.workflow_dispatchtrigger thedockerjob already referenced (manual image re-publish), matching Otis.Depends on OneLiteFeatherNET/workflows#15 (merged + released as
v2.3.0) first — the@v2.3.0refs won't resolve until then. Sequence:v2.3.0.Verification
2.0.1-SNAPSHOT⇒is_snapshot=true.2.0.0(chore(main): release 2.0.0 #129).🤖 Generated with Claude Code