fix: kanata definition of the fn layer does not follow documentation#76
Open
Erwyn wants to merge 1 commit intoOneDeadKey:mainfrom
Open
fix: kanata definition of the fn layer does not follow documentation#76Erwyn wants to merge 1 commit intoOneDeadKey:mainfrom
Erwyn wants to merge 1 commit intoOneDeadKey:mainfrom
Conversation
There are differences between what the documentation of the function layer describes and what the Kanata layout really does about it. This commit should fix: - The function layer is now locked - Pressing lalt or ralt result to a switch to base - lalt and lctl were swapped to match the order of the homerow
Contributor
|
Duplicate of #49? |
Author
|
Hello, yes it is somehow related to this PR. There are two items in mine:
I guess for item The item |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are differences between what the documentation of the function layer describes and what the Kanata layout really does about it. This commit should fix:
I realize 1&2 might have been on purpose in which case the issue is the documentation. I just wanted to provide with a quick fix if it was not the case.
In any event I feel like swapping lalt and lctl is a good thing as it should match the order of the homerows in my opinion.
I would be more than happy to discuss all of this.