Sayali: restore promote button visibility and persist promoted state after refresh#5239
Open
sayali-2308 wants to merge 2 commits into
Open
Sayali: restore promote button visibility and persist promoted state after refresh#5239sayali-2308 wants to merge 2 commits into
sayali-2308 wants to merge 2 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kunchalasireesha
requested changes
May 8, 2026
There was a problem hiding this comment.
PR-5239.mov
Tested the flow everything is working as expected but I feel below changes are needed
- Both confirmation popups/modals are missing bottom spacing/padding, which makes the UI look cramped.
- In the “Select Multiple Reviewers” flow, the “Promote Selected” action bar appears at the bottom-right corner and overlaps/collides with the up-arrow button in the same position.
- Suggestion: move the action bar to the top-right corner for better visibility and to avoid overlap.
HemanthNidamanuru
previously approved these changes
May 8, 2026
|
Contributor
Author
|
Hi, resolved the merge conflict and fixed both issues: (1) repositioned the floating 'Promote Selected' bar higher (bottom: 80px) to avoid overlap, and (2) added padding to the confirmation modal footer so Cancel/Confirm buttons don't touch the edge. Please re-review PR #5239. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Fixes reviewer-reported issue where the 🏆 Promote button was not visible on the PR Grading Screen after PR #5152 was merged. Also fixes "Error saving grades" error when using mock data, and adds localStorage persistence so promoted state survives page refresh.
Related PRS (if any):
Follow-up fix for PR #5152
Main changes explained:
…
How to test:
Screenshots or videos of changes:
Note: