Namitha: Added date and type filters to LB Dashboard with mock data#4718
Open
Namitha7070 wants to merge 1 commit intodevelopmentfrom
Open
Namitha: Added date and type filters to LB Dashboard with mock data#4718Namitha7070 wants to merge 1 commit intodevelopmentfrom
Namitha7070 wants to merge 1 commit intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Anusha-Gali
suggested changes
Jan 23, 2026
There was a problem hiding this comment.
Hi Namitha,
I have reviewed your PR locally and have identified the below issues:
In both light and dark mode:
- Few of the Metric mainly the current value that is shown is not visible when Type - Listing is selected.
- Also i am able to select the to date previous to that of from date.
In dark mode:
- I am unable to see the toggle values in the chart "Demand across Villages" displayed when selected compare by "Village" and "Comparing Ratings of Properties" displayed when selected compare by "Properties" no matter which metric or type is selected.
4718-dark.mp4
4718.mp4
rohanrastogi311
requested changes
Jan 24, 2026
HemanthNidamanuru
requested changes
Apr 25, 2026
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Namitha,
I tested this PR and found a few issues:
- Line graph data labels are sometimes hidden behind the data point dots.
- Bar chart axis values are not visible in dark mode.
- Hovering over the bar chart shows an empty white tooltip with no data.
- The Revenue dropdown does not work when Type is set to "Listing".
- Some line graph colors render incorrectly in dark mode (e.g. dark green).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Related PRS (if any):
…
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Week.24.mp4