Skip to content

Namitha: Added date and type filters to LB Dashboard with mock data#4718

Open
Namitha7070 wants to merge 1 commit intodevelopmentfrom
feature/lb-dashboard-filters
Open

Namitha: Added date and type filters to LB Dashboard with mock data#4718
Namitha7070 wants to merge 1 commit intodevelopmentfrom
feature/lb-dashboard-filters

Conversation

@Namitha7070
Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

Main changes explained:

  • Added filter controls (date range, compare type, listing/bidding), mock data generation keyed to filters, and wired in the new properties ratings graph.
  • Tweaked chart defaults (margins, axis fonts, responsive layout) so graphs render larger and aligned.
  • New component that produces mock property metrics per selected filter/metric and renders through CompareBarGraph.
  • Adjusted card padding and canvas offsets to remove left gutter, plus consolidated dark-mode styles.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ /lbdashboard
  6. verify function, Change From/To dates and confirm: Villages graph and properties graph both update values.
  7. Switch Compare By between Villages and Properties; verify the correct graphs render.
  8. Toggle Type between All, Listing, Bidding; ensure both bar charts adjust their data.
  9. Cycle through metric categories (Demand, Vacancy, Revenue) and different metrics within each; check axis labels, domains, and tooltip values respond accordingly.
  10. Verify dark mode (if available) still applies correctly to the new inputs and charts.

Screenshots or videos of changes:

Week.24.mp4
Screenshot 2026-01-15 152438 Screenshot 2026-01-15 152426 Screenshot 2026-01-15 152416 Screenshot 2026-01-15 152402

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 0704ef8
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/696981d9f5340700086dd1de
😎 Deploy Preview https://deploy-preview-4718--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Namitha,

I have reviewed your PR locally and have identified the below issues:
In both light and dark mode:

  • Few of the Metric mainly the current value that is shown is not visible when Type - Listing is selected.
  • Also i am able to select the to date previous to that of from date.

In dark mode:

  • I am unable to see the toggle values in the chart "Demand across Villages" displayed when selected compare by "Village" and "Comparing Ratings of Properties" displayed when selected compare by "Properties" no matter which metric or type is selected.
4718-dark.mp4
4718.mp4

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Namitha,

Well done with this implementation. A couple issues: on the line graph, the numbers sometimes get obscured by the dots. Also, the highlighting of the bar chart is a big white box.

PR 4718 Screenshot 2 PR 4718 Screenshot

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 24, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Namitha,

I tested this PR and found a few issues:

  1. Line graph data labels are sometimes hidden behind the data point dots.
  2. Bar chart axis values are not visible in dark mode.
  3. Hovering over the bar chart shows an empty white tooltip with no data.
  4. The Revenue dropdown does not work when Type is set to "Listing".
  5. Some line graph colors render incorrectly in dark mode (e.g. dark green).
Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants