Skip to content

Shashank madan location autocomplete#4707

Merged
one-community merged 3 commits intodevelopmentfrom
shashank-madan-location-autocomplete
Jan 23, 2026
Merged

Shashank madan location autocomplete#4707
one-community merged 3 commits intodevelopmentfrom
shashank-madan-location-autocomplete

Conversation

@shashank-madan
Copy link
Copy Markdown
Contributor

@shashank-madan shashank-madan commented Jan 14, 2026 •
edited
Loading

Description

image

Related PRS (if any):

This frontend PR is related to the development branch of the backend

Main changes explained:

  • Extracted mock data into different file
  • Added api calling with fallback to mockdata
  • Fixed the autocomplete functionality to filter only startswith
    …

How to test:

  1. check into current branch
  2. do yarn install and yarn start to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to http://localhost:5173/communityportal/activities
  6. verify that autocomplete shows only suggestions which start with the typed input in the location field
  7. verify this new feature works in dark mode

Screenshots or videos of changes:

HGN.APP.-.Google.Chrome.2026-01-14.12-57-32.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 14, 2026 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 5c48f86
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6967da6bfef93900083f8836
😎 Deploy Preview https://deploy-preview-4707--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 14, 2026

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jan 15, 2026
Anusha-Gali
Anusha-Gali approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

I have reviewed your PR locally and the Location autocomplete works as expected.
Screenshot 2026-01-15 at 6 36 11 PM
Screenshot 2026-01-15 at 6 36 19 PM
Screenshot 2026-01-15 at 6 36 27 PM
Screenshot 2026-01-15 at 6 36 36 PM

rohanrastogi311
rohanrastogi311 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

Well done on this implementation.

PR 4707 Screenshot

Vikas-8055
Vikas-8055 approved these changes Jan 17, 2026
View reviewed changes
Copy link
Copy Markdown

@Vikas-8055 Vikas-8055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi shashank

i have reviewed and tested this pr it works as expected

Screenshot 2026-01-16 at 11 49 17 PM

rohanrastogi311
rohanrastogi311 approved these changes Jan 17, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

Well done with this implementation, dark mode is also functional.

PR 4707 Screenshot

Shravan-neelamsetty
Shravan-neelamsetty approved these changes Jan 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Shravan-neelamsetty Shravan-neelamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,
i have tested this pr and everything is functional.
Screenshot 2026-01-17 at 2 15 23 PM

abdel-lall
abdel-lall approved these changes Jan 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screenshot 2026-01-18 000638

@one-community
Copy link
Copy Markdown
Member

one-community commented Jan 23, 2026

Thank you all, merging!

@one-community one-community merged commit 4467c3e into development Jan 23, 2026
10 checks passed
@one-community one-community mentioned this pull request Feb 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abdel-lall abdel-lall abdel-lall approved these changes

@rohanrastogi311 rohanrastogi311 rohanrastogi311 approved these changes

@Vikas-8055 Vikas-8055 Vikas-8055 approved these changes

@Shravan-neelamsetty Shravan-neelamsetty Shravan-neelamsetty approved these changes

+1 more reviewer

@Anusha-Gali Anusha-Gali Anusha-Gali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shashank-madan @one-community @abdel-lall @rohanrastogi311 @Anusha-Gali @Vikas-8055 @Shravan-neelamsetty