Ramsundar Update current week only on own page by Ram-blip · Pull Request #3742 · OneCommunityGlobal/HighestGoodNetworkApp

Ram-blip · 2025-07-12T06:38:16Z

Description

Video Link: https://www.loom.com/share/5e27c7b0b61144d68c433044c7e97350?sid=60bac4c4-4432-4fd9-84c6-cd1a9447df30

Related PRS (if any):

This frontend PR is related to the latest Development backend branch.

Main changes explained:

Issue:
You're on User B's timelog page, but when you log time:

Your timer data temporarily appears in User B's timelog entries
User B's "Current Week" shows your logged time (ex: 0.53hrs) instead of their time
Refresh fixes it because it reloads the correct data from the server

Fixes:

Added a check to ensure time entries are only re-fetched if the personId of the entry matches the currently displayed user ID.
If the logged entry belongs to a different user than the one currently being viewed, the function exits early and skips dispatching any updates to the timeEntries slice.
By blocking the Redux state update for unrelated users, we prevent User A’s time data from being shown in User B’s UI when User A logs time.

How to test:

check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
log as admin user
go to dashboard
Start timer -> Click any other teammate timelog
In another teammate's timelog, log your time and check if your own "Current Week" is showing there.

Screenshots or videos of changes:

video1011269524.mp4

Note:

Include the information the reviewers need to know.

netlify · 2025-07-12T06:38:49Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`c662b2d`
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/687202daebd8d80008f5973d
😎 Deploy Preview	https://deploy-preview-3742--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

akshith312 · 2025-08-28T21:43:16Z

Checked out with current branch.
Ran npm install and shows version not compatible. Present development branch is in Node 20.
Attaching Screenshot for your reference.

sourabhbagde

Attempted to test the PR branch but was blocked during install due to Node version mismatch. The branch enforces Node 14, while development branch has node 20+

vishnu-ing

Please update the node version in package to v20, unable to build due to version mismatch.

SreePujitha01

Ran npm install but faced compatibility issues since the package requires Node 14 while the development branch is running on Node 20.

khan-zoha

Reviewed PR #3742. The node version needs to be updated to 20+. Got the following error.

munishpatel

Reviewed testing the PR branch but was blocked during install due to Node version mismatch. The branch enforces Node 14, while development branch has node 20+:

RitzzzZ2021

Ran npm install but faced compatibility issues since the package requires Node 14 while the development branch is running on Node 20.

Aditya-gam

When I run npm install to install the repository, this is the error I get:
- What I found was that this branch requires React ^16.14.0 (React 16)
- @react-leaflet/core@1.0.2 requires: React ^17.0.1 (React 17+)
- The conflict: @react-leaflet/core@1.0.2 has peer dependencies that require React 17+, but branch is locked to React 16.
I tried installing node 17 using nvm install 17 and installing using npm install --legacy-peer-deps, but it throws an unsupported engine error.
Even npm install --legacy-peer-deps --force throws an error.
Please provide a fix for this.

laynet

I had the same error as everyone else, node version incompatibility after running npm install.

MeronTeweldebrhan

PR Review Feedback

Testing Outcome

⚠️ Encountered a build issue when running locally:

'react-scripts' is not recognized as an internal or external command,
operable program or batch file.

npm ERR! notsup Required: {"node": ">=14.0.0 <15"}
npm ERR! notsup Actual: {"npm": "10.9.3", "node": "v22.19.0"}

dunstanad · 2025-10-04T13:46:27Z

Unable to run the code because of Node version mismatch.

ShradhaMBhadrannavar

I tried installing dependencies to test this PR, but encountered a dependency conflict error between react@16.14.0 and @react-leaflet/core@1.0.2, which requires React 17+.
The error prevents running the app locally (npm install fails with ERESOLVE unable to resolve dependency tree). Screenshot attached for reference.
Could you please confirm the compatible React version or update the dependency configuration so that it can be installed successfully?

sanjeev29 · 2025-10-09T21:55:40Z

Tested the changes locally on Chrome browser. The changes work as shown in the video above.

sumedhkumar96

Tested the changes by running the frontend changes locally. The admin account is able to see the current week's updates of the candidates.

tomkkl · 2025-10-26T05:08:50Z

Hello,
Unable to compile due to node version mismatch

Vinay944924 · 2025-10-31T18:18:35Z

Hi Rmasundar,
I attempted to test the PR locally but the node version is 14 where as the actual node version is running >20. So please check that. I have provided the screenshot below.

Sriamshreddy000 · 2025-11-07T03:22:52Z

Hey Ramsundar,
I tried running the npm install command, but it seems there’s a compatibility error. Could you please check and confirm if the dependencies are aligned with the current setup?

I am attaching a screenshot below for reference

Anusha-Gali

Hi Ramsundar

I have tested this PR locally - and the code is not running due to the error in the node version. The dev is on version 20+ whereas your code has "node": ">=14.0.0 <15" in the package.json which could be causing this clash. Kindly update it.

ManeeshBuddha21 · 2025-11-09T00:38:23Z

Tried running this PR locally but got a node-sass build error during npm install. Looks like a node-gyp/python distutils issue. Please advise if a specific Node version or dependency update is needed.

Raghu04122002

Reviewed the PR#3742. The changes you have made are working as expected. The user is able to log his time while present on other users timelog

PR3742.mp4

debadyuti23

Hi @Ram-blip while testing your PR I have encountered the same issue as other reviewers mentioned.
npm error engine Not compatible with your version of node/npm: hgnreactapp@0.1.0 npm error notsup Not compatible with your version of node/npm: hgnreactapp@0.1.0 npm error notsup Required: {"node":">=14.0.0 <15"} npm error notsup Actual: {"npm":"10.8.2","node":"v20.19.6"}"
while I tried to install node 14.21.3 it does not integrate with the current backend whose screenshot I have attached.

I would recommend to sync the current development branch changes with your branch accordingly. Also left couple of NIT comments.

debadyuti23 · 2025-12-06T09:28:42Z

  };
 };

+


debadyuti23 · 2025-12-06T09:29:04Z

  };
 };

+


Please do not include comments

VijayAnirudh

There's a version mismatch. Please resolve the version or let me know if you want to bypass the error and test it.

SwathiAngadi · 2025-12-10T01:05:08Z

Hi Ramsundar,
Checked to current branch. Ran npm run start:local found 'react-scripts' is not recognized as an internal or external command. While trying to run npm install found node version mismatch. Could not test the PR.

rohanrastogi311

Hi Ramsundar,

It appears you're using an out-dated Node version which is causing errors with launch. Please check you're on 20.

abhinav-TB · 2026-01-04T23:32:32Z

Hi Ramsundar, I have reviewed your PR but when trying to install the dependecies it requires a lower version of nodejs which is different from the current standard which is v20.

Shravan-neelamsetty

Hi Ramsundar, I attempted to test this PR locally but encountered a Node version compatibility issue. When running npm install, I received the error: npm error notsup Required: {"node":">=14.0.0 <15"} while my system is running Node v20.19.6, which matches the development branch requirements. This version mismatch prevents the installation from completing, making it impossible to test the changes locally.

Vikas-8055

Hey Kanishk, I attempted to test this PR locally but encountered a Node version compatibility issue during npm install. The package.json specifies Node ">=14.0.0 <15" while the project runs on v20.19.6. Could you please update the Node version requirements to align with the current setup?

Ganesh112001

I attempted to test PR #3742, which updates the "Current Week" display to only show on a user's own page and prevent data from appearing on other users' timelogs. However, I encountered multiple dependency and compatibility issues that prevented testing. The PR branch uses outdated dependencies requiring Node.js versions 14-18, but the current development environment runs Node v20. After switching to Node 18, installation still failed due to missing react-scripts and incompatible package-lock.json files created with older npm versions. The old dependencies and engine version conflicts make this PR untestable without significant environment reconfiguration. Recommend updating the PR dependencies to be compatible with current Node.js versions or testing in an environment matching the original development setup from July 2025.

saitejakaasoju · 2026-01-29T05:02:45Z

Hey Kanishk, I tried testing this PR locally, but ran into a Node version compatibility issue during npm install. The current package.json enforces Node >=14.0.0 <15, while the project setup appears to be using Node v20.x. Because of this mismatch, I wasn’t able to run the changes locally.

maithili20 · 2026-01-30T03:33:24Z

Hi @Ram-blip
I tried rewviewing th changes you made in this PR. Seems like there is a version mismatch. Let me know what needs to be done.

naznin07 · 2026-03-07T01:07:55Z

+// const updateTimeEntries = (timeEntry, oldDateOfWork) => {
+//   const startOfWeek = moment().startOf('week');
+
+//   return async dispatch => {


Redundant nested async.

ManojPuttaswamy · 2026-03-13T00:20:05Z

Unable to review because of the node version mismatch. Required node version 14.x.x

SharadhaKasiviswanathan · 2026-04-06T15:59:22Z

+    if (timeEntry.personId !== currentlyViewedUserId) {
+      return; // Don't update Redux if viewing a different user's page
+    }


Tested the current week refresh flow, this might be trying to prevent another user’s page from being updated, but it is checking state.userProfile._id here instead of using the same viewed-user source that is used when the time entry is submitted. This could be checked if the refresh condition is reading the wrong user id, because during profile switching or timer-based submissions the page that just logged time may not refresh correctly.

rajanidi1999

Hi,
I have tested your PR node js should be updated.

rithika-paii

Hi Ramsundar,
I reviewed this PR#3742 by checking out the branch and attempting to run the frontend locally. However, I encountered a setup issue during dependency installation.

The project specifies a Node.js engine requirement of >=14.0.0 <15, while the current development environment uses Node.js v20.x. Because of this mismatch, npm install fails with an EBADENGINE error and the application cannot be started locally.

HemanthNidamanuru

Hi Ramsundar,

The code is not running locally due to a Node version mismatch. The dev environment uses version 20+ but package.json has "node": ">=14.0.0 <15". Please update it.

one-community · 2026-05-09T06:04:31Z

Redone with this PR: #5245

Fixed the issue

c662b2d

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Aug 28, 2025

sourabhbagde requested changes Aug 30, 2025

View reviewed changes

vishnu-ing reviewed Aug 30, 2025

View reviewed changes

SreePujitha01 suggested changes Sep 3, 2025

View reviewed changes

khan-zoha suggested changes Sep 6, 2025

View reviewed changes

munishpatel suggested changes Sep 7, 2025

View reviewed changes

RitzzzZ2021 suggested changes Sep 14, 2025

View reviewed changes

Aditya-gam suggested changes Sep 15, 2025

View reviewed changes

laynet requested changes Sep 22, 2025

View reviewed changes

MeronTeweldebrhan suggested changes Sep 26, 2025

View reviewed changes

ShradhaMBhadrannavar reviewed Oct 4, 2025

View reviewed changes

sanjeev29 approved these changes Oct 9, 2025

View reviewed changes

sumedhkumar96 approved these changes Oct 18, 2025

View reviewed changes

Anusha-Gali suggested changes Nov 8, 2025

View reviewed changes

Raghu04122002 approved these changes Nov 19, 2025

View reviewed changes

debadyuti23 suggested changes Dec 6, 2025

View reviewed changes

VijayAnirudh requested changes Dec 7, 2025

View reviewed changes

rohanrastogi311 suggested changes Dec 27, 2025

View reviewed changes

Shravan-neelamsetty reviewed Jan 9, 2026

View reviewed changes

Vikas-8055 reviewed Jan 10, 2026

View reviewed changes

Ganesh112001 requested changes Jan 17, 2026

View reviewed changes

naznin07 suggested changes Mar 7, 2026

View reviewed changes

SharadhaKasiviswanathan reviewed Apr 6, 2026

View reviewed changes

rajanidi1999 reviewed Apr 16, 2026

View reviewed changes

rithika-paii requested changes Apr 24, 2026

View reviewed changes

HemanthNidamanuru requested changes May 5, 2026

View reviewed changes

Ram-blip mentioned this pull request May 8, 2026

Ramsundar - Fix: Admin/owner timer submission contaminating another user's timelog display #5245

Open

one-community closed this May 9, 2026

Uh oh!

Conversation

Ram-blip commented Jul 12, 2025

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Note:

Uh oh!

netlify Bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for highestgoodnetwork-dev ready!

Uh oh!

akshith312 commented Aug 28, 2025

Uh oh!

sourabhbagde left a comment

Choose a reason for hiding this comment

Uh oh!

vishnu-ing left a comment

Choose a reason for hiding this comment

Uh oh!

SreePujitha01 left a comment

Choose a reason for hiding this comment

Uh oh!

khan-zoha left a comment

Choose a reason for hiding this comment

Uh oh!

munishpatel left a comment

Choose a reason for hiding this comment

Uh oh!

RitzzzZ2021 left a comment

Choose a reason for hiding this comment

Uh oh!

Aditya-gam left a comment

Choose a reason for hiding this comment

Uh oh!

laynet left a comment

Choose a reason for hiding this comment

Uh oh!

MeronTeweldebrhan left a comment

Choose a reason for hiding this comment

Uh oh!

dunstanad commented Oct 4, 2025

Uh oh!

ShradhaMBhadrannavar left a comment

Choose a reason for hiding this comment

Uh oh!

sanjeev29 commented Oct 9, 2025

Uh oh!

sumedhkumar96 left a comment

Choose a reason for hiding this comment

Uh oh!

tomkkl commented Oct 26, 2025

Uh oh!

Vinay944924 commented Oct 31, 2025

Uh oh!

Sriamshreddy000 commented Nov 7, 2025

Uh oh!

Anusha-Gali left a comment

Choose a reason for hiding this comment

Uh oh!

ManeeshBuddha21 commented Nov 9, 2025

Uh oh!

Raghu04122002 left a comment

Choose a reason for hiding this comment

Uh oh!

debadyuti23 left a comment

Choose a reason for hiding this comment

Uh oh!

debadyuti23 Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

debadyuti23 Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

VijayAnirudh left a comment

Choose a reason for hiding this comment

Uh oh!

SwathiAngadi commented Dec 10, 2025

netlify Bot commented Jul 12, 2025 •

edited

Loading

naznin07 Mar 7, 2026 •

edited

Loading

rajanidi1999 left a comment •

edited

Loading