[Excel] (External calls) Add new localhost note for fetch calls #819
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit ef5c070: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
There was a problem hiding this comment.
Pull request overview
This PR adds a new note about local network access requirements when using fetch in Chromium-based browsers and updates the documentation date.
- Updated the documentation date to reflect the current changes
- Added a new bullet point informing users about permission requirements for local network access via
fetchin Chromium-based browsers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit ad3f901: ✅ Validation status: passed
For more details, please refer to the build report. |
| * Document cookies, `localStorage`, and `sessionStorage` objects are not supported. | ||
| * External calls may result in sensitive data being exposed to undesirable endpoints, or external data to be brought into internal workbooks. Your admin can establish firewall protection against such calls. Be sure to check with local policies prior to relying on external calls. | ||
| * Be sure to check the amount of data throughput prior to taking a dependency. For instance, pulling down the entire external dataset may not be the best option and instead pagination should be used to get data in chunks. | ||
| * When using Excel on the web in Chromium-based browsers, `fetch` calls for local network access require users to allow the script when prompted. If the script still fails, contact your IT administrator. |
There was a problem hiding this comment.
Do we want to add something about going into browser settings to check permissions?
chrome://settings/privacy/sitePermissions/allPermissions/localNetworkAccess
The
This lets you fix things if you accidentally click deny.
Do we want to link to the chromium announcement as well?
https://developer.chrome.com/blog/local-network-access
|
Learn Build status updates of commit d00b8f2: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
AlexJerabek
left a comment
AlexJerabek
left a comment
There was a problem hiding this comment.
Approving with one suggestion.
| * External calls may result in sensitive data being exposed to undesirable endpoints, or external data to be brought into internal workbooks. Your admin can establish firewall protection against such calls. Be sure to check with local policies prior to relying on external calls. | ||
| * Be sure to check the amount of data throughput prior to taking a dependency. For instance, pulling down the entire external dataset may not be the best option and instead pagination should be used to get data in chunks. | ||
| * When using Excel on the web in Chromium-based browsers, `fetch` calls for local network access require users to allow the script when prompted. If the script still fails, contact your IT administrator. | ||
| * If a local network access request was denied, this can be adjusted in Chrome by going to Privacy > Site settings > Additional permissions > Local network access. |
There was a problem hiding this comment.
I think we usually bold UI labels.
| * If a local network access request was denied, this can be adjusted in Chrome by going to Privacy > Site settings > Additional permissions > Local network access. | |
| * If a local network access request was denied, this can be adjusted in Chrome by going to **Privacy** > **Site settings** > **Additional permissions** > **Local network access**. |
No description provided.