Skip to content

micro-opmtimise address-filter hashing implementation - NIT-4757#4600

Open
mahdy-nasr wants to merge 2 commits intomasterfrom
micro-optimise-hashing-for-addressfilter
Open

micro-opmtimise address-filter hashing implementation - NIT-4757#4600
mahdy-nasr wants to merge 2 commits intomasterfrom
micro-optimise-hashing-for-addressfilter

Conversation

@mahdy-nasr
Copy link
Copy Markdown
Contributor

As per title, address NIT-4757.

@mahdy-nasr
Copy link
Copy Markdown
Contributor Author

will update destination branch after destination PR get merged.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.23%. Comparing base (50a91e4) to head (badb140).
⚠️ Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4600      +/-   ##
==========================================
- Coverage   34.33%   34.23%   -0.10%     
==========================================
  Files         498      494       -4     
  Lines       59085    58917     -168     
==========================================
- Hits        20286    20173     -113     
+ Misses      35218    35172      -46     
+ Partials     3581     3572       -9     

Base automatically changed from implement-string-hashing-for-address-filtering to master April 3, 2026 16:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

❌ 18 Tests Failed:

Tests completed Failed Passed Skipped
4718 18 4700 0
View the top 3 failed tests by shortest run time
TestAliasingFlaky
Stack Traces | -0.000s run time
=== RUN   TestAliasingFlaky
=== PAUSE TestAliasingFlaky
=== CONT  TestAliasingFlaky
    common_test.go:777: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
INFO [04-03|15:53:58.943] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [04-03|15:53:58.943] P2P server will be useless, neither dialing nor listening
INFO [04-03|15:53:58.944] Started log indexer
WARN [04-03|15:53:58.944] Getting file info                        dir= error="stat : no such file or directory"
TestBatchPosterL1SurplusMatchesBatchGasFlaky
Stack Traces | 0.540s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x207e8d2]

goroutine 16 [running]:
testing.tRunner.func1.2({0x37e7160, 0x62029b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37e7160?, 0x62029b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0xf77900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x7)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc000425340)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:839 +0x725
testing.tRunner(0xc000425340, 0x41b9da8)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465
TestReorgResequencing
Stack Traces | 0.790s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-03|16:01:52.838] Indexed transactions                     blocks=6  txs=10  tail=0 elapsed=20.697ms
INFO [04-03|16:01:52.838] Starting work on payload                 id=0x0352c78b10aca001
INFO [04-03|16:01:52.840] Updated payload                          id=0x0352c78b10aca001 number=162  hash=156bd2..4a87ff txs=1   withdrawals=0 gas=21000      fees=0.002099999998 root=981313..6b003e elapsed=1.387ms
INFO [04-03|16:01:52.841] Updated payload                          id=0x03debb8ad8bd7db3 number=35   hash=05952f..3a1ba6 txs=1   withdrawals=0 gas=142,312    fees=7.1156e-06     root=1ec8af..c030c9 elapsed=6.106ms
INFO [04-03|16:01:52.842] Batch overflow: compressed size limit exceeded compressedSize=247 limit=186 isHeader=false
INFO [04-03|16:01:52.842] Waiting background transaction indexer to exit
INFO [04-03|16:01:52.842] Persisting dirty state                   head=8    root=b075e6..d6cabe layers=8
INFO [04-03|16:01:52.843] Persisted dirty state to disk            size=47.60KiB   elapsed="891.557µs"
INFO [04-03|16:01:52.843] Stopping work on payload                 id=0x03debb8ad8bd7db3 reason=delivery
INFO [04-03|16:01:52.844] Blockchain stopped
INFO [04-03|16:01:52.845] Stopping work on payload                 id=0x0352c78b10aca001 reason=delivery
INFO [04-03|16:01:52.845] Persisted dirty state to disk            size=602.38KiB  elapsed=8.747ms
INFO [04-03|16:01:52.846] Blockchain stopped
INFO [04-03|16:01:52.846] Imported new potential chain segment     number=35   hash=05952f..3a1ba6 blocks=1  txs=1   mgas=0.142  elapsed=4.993ms      mgasps=28.499   triediffs=177.39KiB triedirty=0.00B
INFO [04-03|16:01:52.847] Chain head was updated                   number=35   hash=05952f..3a1ba6 root=1ec8af..c030c9 elapsed="111.528µs"
INFO [04-03|16:01:52.847] Imported new potential chain segment     number=162  hash=156bd2..4a87ff blocks=1  txs=1   mgas=0.021  elapsed=6.832ms      mgasps=3.074    triediffs=557.80KiB triedirty=54.57KiB
INFO [04-03|16:01:52.847] Chain head was updated                   number=162  hash=156bd2..4a87ff root=981313..6b003e elapsed="73.818µs"
INFO [04-03|16:01:52.857] Submitted transaction                    hash=0xd3c5f0a10163d56b34d34c0c1b01bbd5e5f44a907782b8b1bda24c4c57408d6a from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=12  recipient=0x457b1BA688E9854BDbed2f473F7510C476A3dA09 value=0
WARN [04-03|16:01:52.859] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0xa\",\"to\":\"0x43ed718ca2678b0fe216344cb6efbb6ea95f7f9a\",\"gas\":\"0x7532\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0x45655841975740320\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0x36981391b7f4ac0783f0e2906f733f9d2a91ebdbcbba7dee61605f6afa888fb3\",\"s\":\"0x7ed92558f2eb1961d179e726076b338309afe311e588d6a68c53c11da2435eec\",\"yParity\":\"0x0\",\"hash\":\"0xe01e18dfb57c83a37b57f8a9eac8274cdef455ec7c60f3e7873693bc1e16b687\"}" err="nonce too high: address 0x4c0f1daf08315d0238cb794e2Ae2B0cBEDbaC2ea, tx: 10 state: 0"
--- FAIL: TestReorgResequencing (0.79s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@tsahee tsahee assigned joshuacolvin0 and unassigned tsahee Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants