Skip to content

Add set filter ID to the hashData for address filter - NIT-4688#4594

Open
mahdy-nasr wants to merge 1 commit intomasterfrom
add-filter-set-id-hashstore
Open

Add set filter ID to the hashData for address filter - NIT-4688#4594
mahdy-nasr wants to merge 1 commit intomasterfrom
add-filter-set-id-hashstore

Conversation

@mahdy-nasr
Copy link
Copy Markdown
Contributor

Address linear NIT-4688.

Propagate addresses-set-id into our addressfilter project

@mahdy-nasr mahdy-nasr changed the title Add set filter ID to the hashData for address filter Add set filter ID to the hashData for address filter - NIT-4688 Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.55%. Comparing base (50a91e4) to head (91b558b).

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           implement-string-hashing-for-address-filtering    #4594      +/-   ##
==================================================================================
- Coverage                                           34.33%   33.55%   -0.79%     
==================================================================================
  Files                                                 498      498              
  Lines                                               59085    59091       +6     
==================================================================================
- Hits                                                20286    19827     -459     
- Misses                                              35218    35664     +446     
- Partials                                             3581     3600      +19     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

❌ 14 Tests Failed:

Tests completed Failed Passed Skipped
4690 14 4676 0
View the top 3 failed tests by shortest run time
TestParseHashListJSON
Stack Traces | 0.000s run time
=== RUN   TestParseHashListJSON
    service_test.go:263: failed to parse JSON with Sha256 hashing_scheme: invalid filter set ID UUID: invalid UUID length: 0
--- FAIL: TestParseHashListJSON (0.00s)
TestParseHashListJSON
Stack Traces | 0.000s run time
=== RUN   TestParseHashListJSON
    service_test.go:263: failed to parse JSON with Sha256 hashing_scheme: invalid filter set ID UUID: invalid UUID length: 0
--- FAIL: TestParseHashListJSON (0.00s)
TestAliasingFlaky
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-01|16:40:11.267] Starting work on payload                 id=0x0394366ab813d121
INFO [04-01|16:40:11.267] Updated payload                          id=0x0394366ab813d121                      number=44 hash=6d8b86..9196f6 txs=1  withdrawals=0 gas=21000     fees=0.002089408207 root=808e81..5a995a elapsed="239.959µs"
INFO [04-01|16:40:11.267] Stopping work on payload                 id=0x0394366ab813d121                      reason=delivery
INFO [04-01|16:40:11.268] Imported new potential chain segment     number=44 hash=6d8b86..9196f6 blocks=1  txs=1  mgas=0.021 elapsed="336.845µs" mgasps=62.343   triediffs=213.28KiB triedirty=0.00B
INFO [04-01|16:40:11.268] Chain head was updated                   number=44 hash=6d8b86..9196f6 root=808e81..5a995a elapsed="23.779µs"
INFO [04-01|16:40:11.269] Submitted transaction                    hash=0xd4467e282fb18ea7c883d24b52c8aa7e5380a796a6f879b8bff49baf170900c3 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=6  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [04-01|16:40:11.269] Starting work on payload                 id=0x0342fc52692862a2
INFO [04-01|16:40:11.270] Updated payload                          id=0x0342fc52692862a2                      number=45 hash=d44c0d..4c0d2b txs=1  withdrawals=0 gas=21000     fees=0.00209072863  root=6156a1..57bcbf elapsed="267.869µs"
INFO [04-01|16:40:11.270] Stopping work on payload                 id=0x0342fc52692862a2                      reason=delivery
INFO [04-01|16:40:11.270] Imported new potential chain segment     number=45 hash=d44c0d..4c0d2b blocks=1  txs=1  mgas=0.021 elapsed="364.714µs" mgasps=57.579   triediffs=217.37KiB triedirty=0.00B
INFO [04-01|16:40:11.270] Chain head was updated                   number=45 hash=d44c0d..4c0d2b root=6156a1..57bcbf elapsed="22.696µs"
INFO [04-01|16:40:11.271] Ethereum protocol stopped
INFO [04-01|16:40:11.271] Transaction pool stopped
INFO [04-01|16:40:11.271] Persisting dirty state                   head=36 root=2063f9..36d2db layers=36
INFO [04-01|16:40:11.271] Submitted transaction                    hash=0x4d6064e44c7537bf33cf00d602fad132637ea9f1a2c03b60004b0ee87265d2db from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=7  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [04-01|16:40:11.271] Starting work on payload                 id=0x035dc6b72bfca0e7
INFO [04-01|16:40:11.272] Persisted dirty state to disk            size=172.29KiB elapsed="805.231µs"
INFO [04-01|16:40:11.272] Blockchain stopped
INFO [04-01|16:40:11.272] Updated payload                          id=0x035dc6b72bfca0e7                      number=46 hash=cc259a..6f0877 txs=1  withdrawals=0 gas=21000     fees=0.002091884445 root=87abe5..1a994b elapsed="383.229µs"
INFO [04-01|16:40:11.272] Stopping work on payload                 id=0x035dc6b72bfca0e7                      reason=delivery

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@mahdy-nasr mahdy-nasr requested a review from diegoximenes April 2, 2026 08:11
Base automatically changed from implement-string-hashing-for-address-filtering to master April 3, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants