Skip to content

Use message extractor to completely replace inbox reader and tracker code#4593

Open
ganeshvanahalli wants to merge 9 commits intomasterfrom
replace-readerandtracker-with-messageextractor
Open

Use message extractor to completely replace inbox reader and tracker code#4593
ganeshvanahalli wants to merge 9 commits intomasterfrom
replace-readerandtracker-with-messageextractor

Conversation

@ganeshvanahalli
Copy link
Copy Markdown
Contributor

@ganeshvanahalli ganeshvanahalli commented Apr 1, 2026

This PR aims to get rid of pending inbox reader and tracker dependency of nitro nodes, and instead to start using message extractor.

Resolves NIT-4753

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 58.08824% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.11%. Comparing base (192393a) to head (72bc2a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4593      +/-   ##
==========================================
- Coverage   34.20%   34.11%   -0.10%     
==========================================
  Files         494      494              
  Lines       58926    58938      +12     
==========================================
- Hits        20156    20107      -49     
- Misses      35230    35294      +64     
+ Partials     3540     3537       -3     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

❌ 17 Tests Failed:

Tests completed Failed Passed Skipped
4707 17 4690 0
View the top 3 failed tests by shortest run time
TestPruningDBSizeReduction
Stack Traces | 0.000s run time
=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)
TestEndToEnd_ManyEvilValidators
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc002a3c8c0, {0x200b980, 0xc001ce2370})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 204316
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

goroutine 251720 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc001ce2550?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc0023e08c0, {0x200b980, 0xc001ce2550})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 240059
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

goroutine 251719 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc001ce2550?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc0023e0820, {0x200b980, 0xc001ce2550})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 240059
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:356 +0x10bf
TestEndToEnd_ManyEvilValidators/honest_essential_edges_confirmed_by_challenge_win
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc002a3c8c0, {0x200b980, 0xc001ce2370})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 204316
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

goroutine 251720 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc001ce2550?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc0023e08c0, {0x200b980, 0xc001ce2550})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 240059
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

goroutine 251719 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc001ce2550?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc0023e0820, {0x200b980, 0xc001ce2550})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 240059
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:356 +0x10bf

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Base automatically changed from mel-change-delayedmsg-accumulation to master April 2, 2026 15:29
rauljordan
rauljordan previously approved these changes Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants