moved extraposttxfilter hook call before finalise - NIT-4638

[mahdy-nasr]

Address linear issue NIT-4638.

Move extraPostTxFilter to trigger before statedb finalise.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.99%. Comparing base (c4de738) to head (fb4e3b9).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
+ Coverage   34.22%   34.99%   +0.77%     
==========================================
  Files         498      498              
  Lines       59094    59094              
==========================================
+ Hits        20223    20679     +456     
+ Misses      35293    34705     -588     
- Partials     3578     3710     +132     

[github-actions]

❌ 13 Tests Failed:

Tests completed	Failed	Passed	Skipped
4691	13	4678	0

View the top 3 failed tests by shortest run time

TestPruningDBSizeReduction

Stack Traces | 0.000s run time

=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)

TestAliasingFlaky

Stack Traces | -0.000s run time

=== RUN   TestAliasingFlaky
=== PAUSE TestAliasingFlaky
=== CONT  TestAliasingFlaky
    common_test.go:777: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
INFO [04-01|14:17:10.942] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [04-01|14:17:10.942] P2P server will be useless, neither dialing nor listening
INFO [04-01|14:17:10.944] New local node record                    seq=1,775,053,030,943 id=4c73ead0acfb30e6                        ip=127.0.0.1 udp=0 tcp=0
INFO [04-01|14:17:10.944] Started P2P networking                   self=enode://c20f64cf2c8463b5bd9f3cde8ff83abfda861589fccc8154453d508814c18d85b4ed5fc579a2937344af1f378a3abdfe9e606ea16ea983925875a87392aee275@127.0.0.1:0
WARN [04-01|14:17:10.944] Getting file info                        dir= error="stat : no such file or directory"

TestBatchPosterL1SurplusMatchesBatchGasFlaky

Stack Traces | 0.550s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x207b2f2]

goroutine 66 [running]:
testing.tRunner.func1.2({0x37e0900, 0x61f49b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37e0900?, 0x61f49b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x1b2a3900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x6)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc0002c2e00)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:839 +0x725
testing.tRunner(0xc0002c2e00, 0x41b2638)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov