Add exhaustive initialization lint to MessageSyncProgress#4590
Open
cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
Open
Add exhaustive initialization lint to MessageSyncProgress#4590cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
Conversation
Add the `// lint:require-exhaustive-initialization` annotation to the MessageSyncProgress struct and fix all initialization sites to explicitly set every field. Ref OffchainLabs#3121
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
// lint:require-exhaustive-initializationannotation to theMessageSyncProgressstruct inarbnode/mel/messages.goMessageSyncProgress{}literals to explicitly set all fields (BatchSeen,BatchProcessed,MsgCount) with zero values:arbnode/mel/runner/mel.go:266(error return inGetSyncProgress)arbnode/inbox_reader.go:731(error return inGetSyncProgress)arbnode/mel/runner/mel.go:288andarbnode/inbox_reader.go:738) already had all fields setRef #3121
Test plan
arbnode/mel/runnerandarbnodepass unchanged🤖 Generated with Claude Code