Add concurrent-use guard to InitTestLog

changelog/jco-inittestlog-parallel-guard.md

@@ -0,0 +1,2 @@
+### Ignored
+- Add concurrent-use guard to InitTestLog to prevent silent log capture failures in parallel tests

system_tests/message_extraction_layer_test.go

@@ -530,6 +530,7 @@ func TestMessageExtractionLayer_TxStreamerHandleReorg(t *testing.T) {
 
 	builder := NewNodeBuilder(ctx).
 		DefaultConfig(t, true).
+		DontParalellise().
 		WithDelayBuffer(threshold)
 
 	builder.nodeConfig.MessageExtraction.Enable = true

system_tests/seqfeed_test.go

@@ -440,7 +440,7 @@ func TestPopulateFeedBacklog(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 
-	builder := NewNodeBuilder(ctx).DefaultConfig(t, true).WithDatabase(rawdb.DBPebble)
+	builder := NewNodeBuilder(ctx).DefaultConfig(t, true).DontParalellise().WithDatabase(rawdb.DBPebble)
 	builder.BuildL1(t)
 
 	userAccount := "User2"

system_tests/triedb_race_test.go

@@ -11,14 +11,10 @@ import (
 	"github.com/ethereum/go-ethereum/arbitrum"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/rawdb"
-	"github.com/ethereum/go-ethereum/log"
 	"github.com/ethereum/go-ethereum/rpc"
-
-	"github.com/offchainlabs/nitro/util/testhelpers"
 )
 
 func TestTrieDBCommitRace(t *testing.T) {
-	_ = testhelpers.InitTestLog(t, log.LevelError)
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 

system_tests/version_alerter_test.go

@@ -26,7 +26,7 @@ func TestNitroNodeVersionAlerter(t *testing.T) {
 	upgradeDeadline := time.Now().Add(time.Hour).Format(time.RFC3339)
 	msg := "Node version or date is below the minimum requirement, please upgrade"
 
-	builder := NewNodeBuilder(ctx).DefaultConfig(t, false)
+	builder := NewNodeBuilder(ctx).DefaultConfig(t, false).DontParalellise()
 	builder.nodeConfig.VersionAlerterServer.Enable = true
 	builder.nodeConfig.VersionAlerterServer.MinRequiredNitroByVersion = reqNodeVersion
 	builder.nodeConfig.VersionAlerterServer.MinRequiredNitroByDate = reqNodeVersionDate

util/testhelpers/testhelpers.go

@@ -143,7 +143,14 @@ func newLogHandler(t *testing.T) *LogHandler {
 	}
 }
 
+var initTestLogMu sync.Mutex
+
 func InitTestLog(t *testing.T, level slog.Level) *LogHandler {
+	t.Helper()
+	if !initTestLogMu.TryLock() {
+		t.Fatal("InitTestLog called concurrently - this test must not run in parallel")
+	}
+	t.Cleanup(initTestLogMu.Unlock)
 	handler := newLogHandler(t)
 	glogger := log.NewGlogHandler(handler)
 	glogger.Verbosity(level)