Fix fuzz workflow YAML syntax and fuzz test panic on expected errors#4524
Draft
joshuacolvin0 wants to merge 2 commits intomasterfrom
Draft
Fix fuzz workflow YAML syntax and fuzz test panic on expected errors#4524joshuacolvin0 wants to merge 2 commits intomasterfrom
joshuacolvin0 wants to merge 2 commits intomasterfrom
Conversation
Fix three YAML issues in fuzz.yml: two step definitions had `uses:` as separate list items instead of step properties, and the Slack notification payload had a trailing comma (invalid JSON). Also fix FuzzInboxMultiplexer which panicked on errors from Pop() — errors are expected for random input during fuzzing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4524 +/- ##
==========================================
- Coverage 32.68% 32.65% -0.03%
==========================================
Files 497 497
Lines 58890 58890
==========================================
- Hits 19247 19231 -16
- Misses 36272 36283 +11
- Partials 3371 3376 +5 |
ganeshvanahalli
requested changes
Mar 20, 2026
| if err != nil { | ||
| panic(err) | ||
| } | ||
| _, _ = multiplexer.Pop(context.TODO()) |
Contributor
There was a problem hiding this comment.
why are we ignoring the error? any in-line documentation here would be helpful regarding the fuzzing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three YAML issues in fuzz.yml: two step definitions had
uses:asseparate list items instead of step properties, and the Slack notification
payload had a trailing comma (invalid JSON). Also fix FuzzInboxMultiplexer
which panicked on errors from Pop() — errors are expected for random input
during fuzzing.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com