Skip to content

port - add assume-valid flags to bold#4342

Merged
joshuacolvin0 merged 5 commits intov3.9.x-releasefrom
assume-valid
Feb 11, 2026
Merged

port - add assume-valid flags to bold#4342
joshuacolvin0 merged 5 commits intov3.9.x-releasefrom
assume-valid

Conversation

@tsahee
Copy link
Copy Markdown
Contributor

@tsahee tsahee commented Feb 5, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1219 2 1217 0
View the top 2 failed tests by shortest run time
TestVersion30
Stack Traces | 9.690s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mfallible: len 4.12K vs 10.34K�[0;0m
�[90mfallible: deployed to 0xA02062aa4Cb0872315ACA3eA6dBF077d90B2DAC1�[0;0m
    precompile_inclusion_test.go:90: goroutine 455068 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3510, 0xc0207221c0}, {0x4080e80, 0xc12066a1e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0207221c0, {0x4080e80, 0xc12066a1e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0207221c0, 0x1e, {0xc1c55afdb0, 0x6, 0xb0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc0207221c0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0207221c0, 0x3d09728)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (9.69s)
TestVersion40
Stack Traces | 11.160s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mTime to activate hostio-test: 154.16793ms�[0;0m
ERROR[02-06|01:39:06.072] Dangling trie nodes after full cleanup
    precompile_inclusion_test.go:90: goroutine 455069 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3510, 0xc020722380}, {0x4080e80, 0xc11d7e79e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc020722380, {0x4080e80, 0xc11d7e79e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc020722380, 0x28, {0xc1b5a4fdf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc020722380?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc020722380, 0x3d09730)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (11.16s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Copy Markdown
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 changed the title add assume-valid flags to bold port - add assume-valid flags to bold Feb 11, 2026
@joshuacolvin0 joshuacolvin0 merged commit b5b06d0 into v3.9.x-release Feb 11, 2026
16 of 18 checks passed
@joshuacolvin0 joshuacolvin0 deleted the assume-valid branch February 11, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants