Skip to content

Wasmer7#4332

Merged
joshuacolvin0 merged 54 commits intomasterfrom
wasmer7
Mar 18, 2026
Merged

Wasmer7#4332
joshuacolvin0 merged 54 commits intomasterfrom
wasmer7

Conversation

@rory-ocl
Copy link
Copy Markdown
Contributor

@rory-ocl rory-ocl commented Feb 4, 2026

Includes upgrade to wasmer 7.1.0-rc.2 and Rust 1.93.

@rory-ocl rory-ocl marked this pull request as draft February 4, 2026 21:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2026

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
4533 12 4521 0
View the top 3 failed tests by shortest run time
TestPruningDBSizeReduction
Stack Traces | 0.000s run time
=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.170s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 248
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
WARN [03-18|20:51:07.038] Served datastreaming_start               conn=127.0.0.1:44948 reqid=7 duration="113.261µs" err="too much time has elapsed since request was signed"
INFO [03-18|20:51:07.038] rpc response                             method=datastreaming_start logId=7 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x69bb103a\", \"0x2f\", \"0xd9\", \"0x2711\", \"0xa\", \"0x15059f095071c18a6cdd686f5e19498c86941d1d353860a075d9e4e483b9e38f39f24de244fd014d7803e4af4bdb84f741f51a319d08ed1f7c7459d49e28832e01\"]" errorData=null
    protocol_test.go:230: goroutine 258 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x156fa10, 0xc000814540}, {0x15564c0, 0xc0000ff2f0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 248
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.17s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.200s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.20s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.65%. Comparing base (ef87792) to head (511566c).
⚠️ Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4332      +/-   ##
==========================================
- Coverage   34.54%   32.65%   -1.89%     
==========================================
  Files         497      497              
  Lines       58813    58816       +3     
==========================================
- Hits        20318    19208    -1110     
- Misses      34887    36227    +1340     
+ Partials     3608     3381     -227     

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
@bragaigor bragaigor marked this pull request as ready for review March 18, 2026 14:34
@bragaigor bragaigor self-assigned this Mar 18, 2026
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Comment on lines +141 to +144
// msg_value hostio is called twice: once by the deny_value payability guard
// and once by the method body itself.
hostio: "msg_value",
expectedInk: HOSTIO_INK + PTR_INK,
expectedInk: []uint64{HOSTIO_INK + PTR_INK, HOSTIO_INK + PTR_INK},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment #4332 (comment)

@@ -66,7 +67,7 @@ func TestProgramSimpleCost(t *testing.T) {
{hostio: "math_add_mod", opcode: vm.ADDMOD, params: []any{big.NewInt(1), big.NewInt(3), big.NewInt(5)}, maxDiff: 0.7},
{hostio: "math_mul_mod", opcode: vm.MULMOD, params: []any{big.NewInt(1), big.NewInt(3), big.NewInt(5)}, maxDiff: 0.7},
{hostio: "msg_sender", opcode: vm.CALLER, maxDiff: 0.5},
{hostio: "msg_value", opcode: vm.CALLVALUE, maxDiff: 0.5},
{hostio: "msg_value", opcode: vm.CALLVALUE, maxDiff: 0.5, mode: compareGasSum},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment #4332 (comment)

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Copy link
Copy Markdown
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge March 18, 2026 20:57
@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Mar 18, 2026
Merged via the queue into master with commit 9a3a0ed Mar 18, 2026
27 checks passed
@joshuacolvin0 joshuacolvin0 deleted the wasmer7 branch March 18, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants