Add sequencer queue and tx size metrics#4317
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
===========================================
+ Coverage 33.98% 57.55% +23.56%
===========================================
Files 488 488
Lines 57783 57807 +24
===========================================
+ Hits 19640 33268 +13628
+ Misses 34672 19598 -15074
- Partials 3471 4941 +1470 |
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
|
@tsahee, there is some sensitivity for this review. Please take a look. I've reviewed it, and I don't see anything I'd like to change. But, I know you might be able to spot something I've missed. |
| for { | ||
| if len(queueItems) == 1 { | ||
| startOfReadingFromTxQueue = time.Now() | ||
| waitForTxHistogram.Update(int64(time.Since(startOfBlockCreation))) |
There was a problem hiding this comment.
I'd check and if that's less than 1ms (or possibly config.ReadFromTxQueueTimeout), put in zero. We don't need to deal with history of how long it took to do the first loop.
There was a problem hiding this comment.
I'm adding the capping below 1ms.
I thin the config.ReadFromTxQueueTimeout is a different timeout that starts when wait for tx ends.
Resolves NIT-4418
This PR adds:
arb/sequencer/block/txsizeandarb/sequencer/transactions/txsizehistogramsarb/sequencer/queue/normal,arb/sequencer/queue/timeboost,arb/sequencer/queue/histogram/normal,arb/sequencer/queue/histogram/timeboost,arb/sequencer/waitfortxarb/sequencer/block/gasfull,arb/sequencer/block/datafull,arb/sequencer/block/txexhausted