Conversation
| parentRpcUrl, | ||
| childRpcUrl, | ||
| parentWalletClient, | ||
| childWalletClient, |
There was a problem hiding this comment.
I don't think we need the childWalletClient here
There was a problem hiding this comment.
Actually, I would not request any client here, and just create everything within the function
There was a problem hiding this comment.
could you clarify? typically, the consumer will want control of their clients, no?
There was a problem hiding this comment.
If they want to keep control on their client, they can extend with actions on their own. I would expect createArbitrumClient to do every thing for me and create the clients not extend them. But it's not an issue.
| parentRpcUrl, | ||
| childRpcUrl, | ||
| parentWalletClient, | ||
| childWalletClient, |
There was a problem hiding this comment.
If they want to keep control on their client, they can extend with actions on their own. I would expect createArbitrumClient to do every thing for me and create the clients not extend them. But it's not an issue.
3 participants
No description provided.