vibe: this is an implementation spike of the planned items for review#1
Merged
Merged
Conversation
ask: one small change I want to get in with this feature set, prob doesn't need a ticket... but when the "terminal view" of htop to terminal was implemented, it's printing each node out line-by-line... which is to be expected. But can we make this behavior from a '-l --list' flag and instead we "wrap" these outputs into "cells" across the terminal and then wrap/stack those like "bricks" It gets difficult because we don't want their positions changing randomly... and also the terminal is drawn line by line, so we'd have to get clever with curses or something to accomplish this maybe? If this is _not_ a small change, maybe we do need to plan this out in a ticket? codex-5.5-medium: Worked for 1m 46s Implemented it as a small change, no new ticket needed. Terminal mirror behavior now: Default: renders nodes as stable, sorted “brick” cells across the terminal width. -l / --list: keeps the previous vertical list rendering. Details: Uses deterministic name sorting, so nodes do not jump around randomly. Packs cells based on COLUMNS, falling back to width 100. Composes the full frame as text before redraw, so no curses dependency is needed. Verification: GOCACHE=/tmp/psstd-go-build go test ./... passes.
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.