Skip to content

[6000.0] Fixed Custom URP Compile errors, prepared for test project integration#61

Open
JessAtMeta wants to merge 6 commits into
Oculus-VR:6000.0/oculus-app-spacewarpfrom
JessAtMeta:6.0/asw
Open

[6000.0] Fixed Custom URP Compile errors, prepared for test project integration#61
JessAtMeta wants to merge 6 commits into
Oculus-VR:6000.0/oculus-app-spacewarpfrom
JessAtMeta:6.0/asw

Conversation

@JessAtMeta

@JessAtMeta JessAtMeta commented Jul 24, 2026

Copy link
Copy Markdown

Fixed up 6000.0 compilation;

  • Restored TraceRayAndQueryHit.hlsl as referenced from origin/master
  • Hard set isIndirectSupported in InstanceCullingBatcher.cs (as this branch is ONLY for 6000.0 support, the upstream changes work as of 6.1),
  • Updated constants / keyword usage in ShaderScriptableStripperTests.cs.
  • Vendored UnifiedRTShaderImporter.cs into the project to give raytrace shaders a valid importer.

Purpose of this PR

Users were getting compile errors when opening projects including the following packages:

com.unity.render-pipelines.core@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.core#6000.0/oculus-app-spacewarp
com.unity.render-pipelines.universal@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.universal#6000.0/oculus-app-spacewarp
com.unity.shadergraph@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.shadergraph#6000.0/oculus-app-spacewarp
The console should be clear of errors when loading these packages.


Testing status

  • The Graphics Repo as a project compiles locally
  • Including some project-scope changes, (in the ASW6.0 [c03014335095] bookmark), the unity-appspacewarp test project builds properly with functional motion vectors

Comments to reviewers

  • To test, make sure that you're using git+ssh://git@github.example.com/JessAtMeta/Unity-Graphics.git#6.0/asw for Graphics package references, e.g.
    "com.unity.render-pipelines.core": "git+ssh://git@github.example.com/JessAtMeta/Unity-Graphics.git#6.0/asw",
    "com.unity.render-pipelines.universal": "git+ssh://git@github.example.com/JessAtMeta/Unity-Graphics.git#6.0/asw",
    "com.unity.shadergraph": "git+ssh://git@github.example.com/JessAtMeta/Unity-Graphics.git#6.0/asw",

Once this work is landed, these paths will need to be updated to:

    "com.unity.render-pipelines.core": "git+ssh://git@github.example.com/Oculus-VR/Unity-Graphics.git#6000.0/oculus-app-spacewarp",
    "com.unity.render-pipelines.universal": "git+ssh://git@github.example.com/Oculus-VR/Unity-Graphics.git#6000.0/oculus-app-spacewarp",
    "com.unity.shadergraph": "git+ssh://git@github.example.com/Oculus-VR/Unity-Graphics.git#6000.0/oculus-app-spacewarp",

@JessAtMeta
JessAtMeta marked this pull request as ready for review July 24, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant