Updating description of package id. #1646
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please delete everything above the line below.
Background
The instructions in the Parameter gave the example of
#{Octopus.Action.Package[Template.Azure.Container.Image].PackageId}. In situations where there was an organization preceding the package name, ie. octopussamples/ocopub-frontend, the container name was being set tooctopussamples/octopub-frontend. The/would cause issues and make the registration think it needed to be in a subfolder.Results
The change updates the example from
#{Octopus.Action.Package[Template.Azure.Container.Image].PackageId}to `#{Octopus.Action.Package[Template.Azure.Container.Image].PackageId | Replace "/" "-"}Before
Setting the name to the example would result in step failure.
After
The character replacement results in a valid container name;
octopussamples-octopub-frontendPre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line