Skip to content

Classify Windows TCP connect timeout as a network error #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhysparry wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Classify Windows TCP connect timeout as a network error #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/Halibut/Diagnostics/ExceptionReturnedByHalibutProxyExtensionMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ public static HalibutNetworkExceptionType IsNetworkError(this Exception exceptio
if (exception.Message.Contains("The remote party closed the WebSocket connection without completing the close handshake.")) return HalibutNetworkExceptionType.IsNetworkError;
if (exception.Message.Contains("Unable to read data from the transport connection: Operation timed out.")) return HalibutNetworkExceptionType.IsNetworkError;
if (exception.Message.Contains("Unable to write data to the transport connection: Operation timed out.")) return HalibutNetworkExceptionType.IsNetworkError;

if (exception.Message.Contains("The client was unable to establish the initial connection within the timeout")) return HalibutNetworkExceptionType.IsNetworkError;

}

return HalibutNetworkExceptionType.UnknownError;
Expand Down