Skip to content

Excess drift reporting#2

Merged
borland merged 4 commits into
mainfrom
orion/excess-drift
Jul 12, 2026
Merged

Excess drift reporting#2
borland merged 4 commits into
mainfrom
orion/excess-drift

Conversation

@borland

@borland borland commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Microsoft have asked us if we can capture the state of VM's experiencing excess drift.

Claude implements the following changes, in this PR.

  • Add a new event to log, with EventId 1500, and message "Excess Drift Detected"

  • Update the monitoring logic so that if it observes three consecutive measurements where the drift is more than 60 seconds away from "true" time, it logs this event, and also writes a new file EXCESS_DRIFT to the same folder as the log output.

    • It should only log the event once
    • If the EXCESS_DRIFT file is already there, it should not be an error
    • The EXCESS_DRIFT file should be empty, just a placeholder

Note: Drift can be either positive or negative 60 seconds away; both are considered errors

Note: A "good" measurement after an excess one resets the logic; we need three CONSECUTIVE measurements to trip the state

@borland borland force-pushed the orion/excess-drift branch from c390455 to e3d8901 Compare July 12, 2026 21:59
Comment thread .github/workflows/main.yaml Outdated

- name: Publish AOT exe
if: github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
#if: github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally committed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just so I could publish a pre-release and use it from TeamCity. Not meant to merge to main though, I'll roll back

@rosslovas rosslovas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable!

@borland borland merged commit 114418c into main Jul 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants