Skip to content

core: 0-based index for parsig metric #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obol-bulldozer merged 1 commit into from
Feb 13, 2026
Merged

core: 0-based index for parsig metric #4322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/parsigdb/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ func (db *MemDB) store(k key, value core.ParSignedData) ([]core.ParSignedData, b
default:
}

parsigStored.WithLabelValues(k.Duty.Type.String(), strconv.FormatInt(int64(value.ShareIdx), 10)).Observe(timeSinceSlotStart)
// Observe time since slot start for received partial signatures, with share index as label for better visibility of late partial signatures.
// Subtracting 1 from share index to have 0-based index.
parsigStored.WithLabelValues(k.Duty.Type.String(), strconv.FormatInt(int64(value.ShareIdx-1), 10)).Observe(timeSinceSlotStart)

for _, s := range db.entries[k] {
if s.ShareIdx == value.ShareIdx {
Expand Down
Loading