fix: correct game summary link in player live view#2460
Open
Adarshkumar0509 wants to merge 4 commits intoOWASP:masterfrom
Open
fix: correct game summary link in player live view#2460Adarshkumar0509 wants to merge 4 commits intoOWASP:masterfrom
Adarshkumar0509 wants to merge 4 commits intoOWASP:masterfrom
Conversation
Adarshkumar0509
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
Contributor
Author
|
@sydseter the pr is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2458
Problem
The "Go to game summary" button in player_live/show.html.heex used
a relative URL "../" which caused an HTTP 500 error instead of
navigating to the game summary page.
"../" from /games/{game_id}/players/{player_id} resolves to
/games/{game_id}/players/ which throws a 500 error.
Fix
Replaced "../" with the correct Phoenix route helper:
~p"/games/#{@player.game_id}"
Changes