fix: add Redis setup instructions and handle missing Redis connection gracefully#776
Open
rashmivemuri wants to merge 2 commits intoOWASP:mainfrom
Open
fix: add Redis setup instructions and handle missing Redis connection gracefully#776rashmivemuri wants to merge 2 commits intoOWASP:mainfrom
rashmivemuri wants to merge 2 commits intoOWASP:mainfrom
Conversation
Added error handling for Redis connection failure. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
Added instructions to start required services before running locally. Signed-off-by: Rashmi Vemuri <rashmivemuri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
Problem
When running OpenCRE locally, the map analysis feature fails with a Redis
connection error because the setup documentation does not mention starting
Redis before running the app.
Changes
docs/developmentSetup.md - Added
make start-containersstep in theRunning Locally section so users know to start Redis and Neo4j first.
application/utils/gap_analysis.py - Added a None check after
redis.connect() so if Redis is unavailable, the app returns a clear
error message instead of crashing.